Set RtcpSender transport at construction.

webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 63 matching lines @@
   ModuleRtpRtcpImpl* dummy_rtp_rtcp_impl_;
   rtc::scoped_ptr<ReceiveStatistics> receive_statistics_;
   RTCPSender* rtcp_sender_;
   RTCPReceiver* rtcp_receiver_;
   TestTransport* test_transport_;
   MockRemoteBitrateObserver remote_bitrate_observer_;
   rtc::scoped_ptr<RemoteBitrateEstimator> remote_bitrate_estimator_;
 };
 
 void RtcpFormatRembTest::SetUp() {
+  rtcp_receiver_ = new RTCPReceiver(system_clock_, false, nullptr, nullptr,
+                                    nullptr, dummy_rtp_rtcp_impl_);
+  test_transport_ = new TestTransport(rtcp_receiver_);
   RtpRtcp::Configuration configuration;
   configuration.audio = false;
   configuration.clock = system_clock_;
   configuration.remote_bitrate_estimator = remote_bitrate_estimator_.get();
+  configuration.outgoing_transport = test_transport_;
   dummy_rtp_rtcp_impl_ = new ModuleRtpRtcpImpl(configuration);
-  rtcp_sender_ =
-      new RTCPSender(false, system_clock_, receive_statistics_.get(), NULL);
-  rtcp_receiver_ = new RTCPReceiver(system_clock_, false, NULL, NULL, NULL,
-                                    dummy_rtp_rtcp_impl_);
-  test_transport_ = new TestTransport(rtcp_receiver_);
-
-  EXPECT_EQ(0, rtcp_sender_->RegisterSendTransport(test_transport_));
+  rtcp_sender_ = new RTCPSender(false, system_clock_, receive_statistics_.get(),
+                                nullptr, test_transport_);

[pbos-webrtc, 2015/09/24 11:52:02]

Since this isn't using configuration or dummy_..., can you create this one after
test_transport_?

[sprang_webrtc, 2015/09/24 12:08:10]

Done.

 }
 
 void RtcpFormatRembTest::TearDown() {
   delete rtcp_sender_;
   delete rtcp_receiver_;
   delete dummy_rtp_rtcp_impl_;
   delete test_transport_;
 }
 
 TEST_F(RtcpFormatRembTest, TestRembStatus) {
@@ skipping 15 matching lines @@
 
 TEST_F(RtcpFormatRembTest, TestCompund) {
   uint32_t SSRCs[2] = {456789, 98765};
   rtcp_sender_->SetRTCPStatus(kRtcpCompound);
   rtcp_sender_->SetREMBData(1234, std::vector<uint32_t>(SSRCs, SSRCs + 2));
   RTCPSender::FeedbackState feedback_state =
       dummy_rtp_rtcp_impl_->GetFeedbackState();
   EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state, kRtcpRemb));
 }
 }  // namespace