Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1365043002: Set RtcpSender transport at construction. (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set RtcpSender transport at construction. BUG= Committed: https://crrev.com/86fd9ed6f9e2a38aa343db8c62764659633231fa Cr-Commit-Position: refs/heads/master@{#10106}

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Addressed comment #

Patch Set 4 : Rebase + cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -49 lines) Patch
M webrtc/modules/modules.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 3 6 chunks +7 lines, -20 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 2 3 5 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
sprang_webrtc
Cleanup
5 years, 2 months ago (2015-09-24 11:47:26 UTC) #1
sprang_webrtc
5 years, 2 months ago (2015-09-24 11:47:43 UTC) #3
pbos-webrtc
lgtm, +r stefan@ for OWNERS https://codereview.webrtc.org/1365043002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc (right): https://codereview.webrtc.org/1365043002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc#newcode94 webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc:94: nullptr, test_transport_); Since this ...
5 years, 2 months ago (2015-09-24 11:52:02 UTC) #5
sprang_webrtc
https://codereview.webrtc.org/1365043002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc (right): https://codereview.webrtc.org/1365043002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc#newcode94 webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc:94: nullptr, test_transport_); On 2015/09/24 11:52:02, pbos-webrtc wrote: > Since ...
5 years, 2 months ago (2015-09-24 12:08:10 UTC) #6
stefan-webrtc
lgtm
5 years, 2 months ago (2015-09-29 07:44:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365043002/40001
5 years, 2 months ago (2015-09-29 08:11:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/2338) ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, ...
5 years, 2 months ago (2015-09-29 08:11:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365043002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365043002/60001
5 years, 2 months ago (2015-09-29 11:44:44 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-09-29 11:45:48 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 11:46:00 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/86fd9ed6f9e2a38aa343db8c62764659633231fa
Cr-Commit-Position: refs/heads/master@{#10106}

Powered by Google App Engine
This is Rietveld 408576698