Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1364093002: Remove SetAudioDelayOffset() and friends. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@lj_remove_getcapabilities
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove SetAudioDelayOffset() and friends. BUG=webrtc:4690 Committed: https://crrev.com/4a3ccad29e4f14c4a66d10edda0d364ea415e309 Cr-Commit-Position: refs/heads/master@{#10047}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -50 lines) Patch
M talk/media/base/fakemediaengine.h View 4 chunks +1 line, -9 lines 0 comments Download
M talk/media/base/mediaengine.h View 4 chunks +0 lines, -10 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M talk/session/media/channelmanager.h View 1 4 chunks +2 lines, -6 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 5 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
the sun
5 years, 3 months ago (2015-09-23 22:39:59 UTC) #2
pthatcher1
lgtm
5 years, 3 months ago (2015-09-24 06:40:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364093002/40001
5 years, 3 months ago (2015-09-24 09:13:44 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-24 10:53:12 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 10:53:21 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4a3ccad29e4f14c4a66d10edda0d364ea415e309
Cr-Commit-Position: refs/heads/master@{#10047}

Powered by Google App Engine
This is Rietveld 408576698