Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: talk/media/base/mediaengine.h

Issue 1364093002: Remove SetAudioDelayOffset() and friends. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@lj_remove_getcapabilities
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/fakemediaengine.h ('k') | talk/media/webrtc/webrtcvoiceengine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/base/mediaengine.h
diff --git a/talk/media/base/mediaengine.h b/talk/media/base/mediaengine.h
index d739804203da2ca93603cb70615e2bd4c2ecd540..8468e07293aa6521f5b814a471db50314d815d2e 100644
--- a/talk/media/base/mediaengine.h
+++ b/talk/media/base/mediaengine.h
@@ -64,9 +64,6 @@ class VideoCapturer;
// proper synchronization between both media types.
class MediaEngineInterface {
public:
- // Default value to be used for SetAudioDelayOffset().
- static const int kDefaultAudioDelayOffset;
-
virtual ~MediaEngineInterface() {}
// Initialization
@@ -93,9 +90,6 @@ class MediaEngineInterface {
virtual AudioOptions GetAudioOptions() const = 0;
// Sets global audio options. "options" are from AudioOptions, above.
virtual bool SetAudioOptions(const AudioOptions& options) = 0;
- // Sets the value used by the echo canceller to offset delay values obtained
- // from the OS.
- virtual bool SetAudioDelayOffset(int offset) = 0;
// Sets the default (maximum) codec/resolution and encoder option to capture
// and encode video.
virtual bool SetDefaultVideoEncoderConfig(const VideoEncoderConfig& config)
@@ -182,9 +176,6 @@ class CompositeMediaEngine : public MediaEngineInterface {
virtual bool SetAudioOptions(const AudioOptions& options) {
return voice_.SetOptions(options);
}
- virtual bool SetAudioDelayOffset(int offset) {
- return voice_.SetDelayOffset(offset);
- }
virtual bool SetDefaultVideoEncoderConfig(const VideoEncoderConfig& config) {
return video_.SetDefaultEncoderConfig(config);
}
@@ -243,7 +234,6 @@ class NullVoiceEngine {
VoiceMediaChannel* CreateChannel(const AudioOptions& options) {
return nullptr;
}
- bool SetDelayOffset(int offset) { return true; }
AudioOptions GetOptions() const { return AudioOptions(); }
bool SetOptions(const AudioOptions& options) { return true; }
bool SetDevices(const Device* in_device, const Device* out_device) {
« no previous file with comments | « talk/media/base/fakemediaengine.h ('k') | talk/media/webrtc/webrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698