Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1364083002: Remove ChannelManager::GetCapabilities() (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ChannelManager::GetCapabilities() BUG=webrtc:4690 Committed: https://crrev.com/61e933eac7673feb2f8663c3e71e503b714b350f Cr-Commit-Position: refs/heads/master@{#10045}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M talk/media/base/fakemediaengine.h View 2 chunks +0 lines, -2 lines 0 comments Download
M talk/media/base/mediaengine.h View 4 chunks +0 lines, -7 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/session/media/channelmanager.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 1364093002 Patch 20001

Messages

Total messages: 12 (5 generated)
the sun
5 years, 2 months ago (2015-09-23 22:34:28 UTC) #2
pthatcher1
lgtm
5 years, 2 months ago (2015-09-24 06:41:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364083002/20001
5 years, 2 months ago (2015-09-24 07:48:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/9568)
5 years, 2 months ago (2015-09-24 08:10:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364083002/20001
5 years, 2 months ago (2015-09-24 08:14:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-24 08:45:40 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 08:45:51 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/61e933eac7673feb2f8663c3e71e503b714b350f
Cr-Commit-Position: refs/heads/master@{#10045}

Powered by Google App Engine
This is Rietveld 408576698