Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1361773005: Reland of TransportController refactoring. (Closed)

Created:
5 years, 3 months ago by Taylor Brandstetter
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of TransportController refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/1358413003/ ) Reason for revert: This CL just landed: https://codereview.chromium.org/1323243006/ Which fixes the FYI bots for the original CL, and breaks them for this revert. Original issue's description: > Revert of TransportController refactoring. (patchset #6 id:100001 of https://codereview.webrtc.org/1350523003/ ) > > Reason for revert: > This CL causes problems with the WebRTC-in-Chromium FYI bots. Presumably it needs to be done in several steps, where removed files are emptied instead of removed in the first step. > > Original issue's description: > > TransportController refactoring. > > > > Getting rid of TransportProxy, and in its place adding a > > TransportController class which will facilitate access to and manage > > the lifetimes of Transports. These Transports will now be accessed > > solely from the worker thread, simplifying their implementation. > > > > This refactoring also pulls Transport-related code out of BaseSession. > > Which means that BaseChannels will now rely on the TransportController > > interface to create channels, rather than BaseSession. > > > > Committed: https://crrev.com/47ee2f3b9f33e8938948c482c921d4e13a3acd83 > > Cr-Commit-Position: refs/heads/master@{#10022} > > TBR=pthatcher@webrtc.org,deadbeef@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/a81a42f584baa0d93a4b93da9632415e8922450c > Cr-Commit-Position: refs/heads/master@{#10024} TBR=pthatcher@webrtc.org,torbjorng@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/cbecd358e032021eac11fb13e04ec7f070d4f407 Cr-Commit-Position: refs/heads/master@{#10036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3777 lines, -3620 lines) Patch
M talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m View 2 chunks +8 lines, -2 lines 0 comments Download
M talk/app/webrtc/objctests/RTCPeerConnectionTest.mm View 1 chunk +4 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 21 chunks +99 lines, -73 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 9 chunks +34 lines, -24 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 34 chunks +278 lines, -199 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 36 chunks +211 lines, -112 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.h View 1 chunk +6 lines, -7 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/session/media/channel.h View 12 chunks +41 lines, -28 lines 0 comments Download
M talk/session/media/channel.cc View 19 chunks +143 lines, -87 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 36 chunks +105 lines, -60 lines 0 comments Download
M talk/session/media/channelmanager.h View 3 chunks +12 lines, -11 lines 0 comments Download
M talk/session/media/channelmanager.cc View 6 chunks +25 lines, -32 lines 0 comments Download
M talk/session/media/channelmanager_unittest.cc View 8 chunks +42 lines, -31 lines 0 comments Download
M webrtc/base/fakenetwork.h View 4 chunks +13 lines, -20 lines 0 comments Download
M webrtc/p2p/base/dtlstransport.h View 7 chunks +23 lines, -32 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 8 chunks +26 lines, -29 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 4 chunks +17 lines, -24 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 14 chunks +44 lines, -50 lines 0 comments Download
D webrtc/p2p/base/fakesession.h View 1 chunk +0 lines, -506 lines 0 comments Download
A webrtc/p2p/base/faketransportcontroller.h View 1 chunk +537 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.h View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 9 chunks +22 lines, -25 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 15 chunks +58 lines, -70 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 33 chunks +62 lines, -71 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 3 chunks +11 lines, -7 lines 0 comments Download
M webrtc/p2p/base/portallocator.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/p2p/base/session.h View 8 chunks +15 lines, -284 lines 0 comments Download
M webrtc/p2p/base/session.cc View 9 chunks +45 lines, -602 lines 0 comments Download
D webrtc/p2p/base/session_unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M webrtc/p2p/base/transport.h View 15 chunks +106 lines, -154 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 17 chunks +271 lines, -525 lines 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 5 chunks +4 lines, -21 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 3 chunks +10 lines, -6 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 4 chunks +13 lines, -13 lines 0 comments Download
D webrtc/p2p/base/transportchannelproxy.h View 1 chunk +0 lines, -96 lines 0 comments Download
D webrtc/p2p/base/transportchannelproxy.cc View 1 chunk +0 lines, -276 lines 0 comments Download
A webrtc/p2p/base/transportcontroller.h View 1 chunk +196 lines, -0 lines 0 comments Download
A webrtc/p2p/base/transportcontroller.cc View 1 chunk +575 lines, -0 lines 0 comments Download
A webrtc/p2p/base/transportcontroller_unittest.cc View 1 chunk +679 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/p2p_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Taylor Brandstetter
Created Reland of TransportController refactoring.
5 years, 3 months ago (2015-09-23 18:37:45 UTC) #1
Taylor Brandstetter
5 years, 3 months ago (2015-09-23 18:38:28 UTC) #2
pthatcher1
lgtm
5 years, 3 months ago (2015-09-23 18:47:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361773005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361773005/1
5 years, 3 months ago (2015-09-23 18:50:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 18:50:33 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 18:50:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbecd358e032021eac11fb13e04ec7f070d4f407
Cr-Commit-Position: refs/heads/master@{#10036}

Powered by Google App Engine
This is Rietveld 408576698