Reland of TransportController refactoring.

talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m

 /*
  * libjingle
  * Copyright 2013 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 178 matching lines @@
 }
 
 - (void)peerConnection:(RTCPeerConnection*)peerConnection
     iceGatheringChanged:(RTCICEGatheringState)newState {
   // It's fine to get a variable number of GATHERING messages before
   // COMPLETE fires (depending on how long the test runs) so we don't assert
   // any particular count.
   if (newState == RTCICEGatheringGathering) {
     return;
   }
+  NSAssert([_expectedICEGatheringChanges count] > 0,
+           @"Unexpected ICE gathering state change");
   int expectedState = [self popFirstElementAsInt:_expectedICEGatheringChanges];
-  NSAssert(expectedState == (int)newState, @"Empty expectation array");
+  NSAssert(expectedState == (int)newState,
+           @"ICE gathering state should match expectation");
 }
 
 - (void)peerConnection:(RTCPeerConnection*)peerConnection
   iceConnectionChanged:(RTCICEConnectionState)newState {
   // See TODO(fischman) in RTCPeerConnectionTest.mm about Completed.
   if (newState == RTCICEConnectionCompleted)
     return;
+  NSAssert([_expectedICEConnectionChanges count] > 0,
+           @"Unexpected ICE connection state change");
   int expectedState = [self popFirstElementAsInt:_expectedICEConnectionChanges];
-  NSAssert(expectedState == (int)newState, @"Empty expectation array");
+  NSAssert(expectedState == (int)newState,
+           @"ICE connection state should match expectation");
 }
 
 - (void)peerConnection:(RTCPeerConnection*)peerConnection
     didOpenDataChannel:(RTCDataChannel*)dataChannel {
   NSString* expectedLabel =
       [self popFirstElementAsNSString:_expectedDataChannels];
   NSAssert([expectedLabel isEqual:dataChannel.label],
            @"Data channel not expected");
   self.dataChannel = dataChannel;
   dataChannel.delegate = self;
@@ skipping 22 matching lines @@
            @"Unexpected message received");
   RTCDataBuffer* expectedBuffer = [_expectedMessages objectAtIndex:0];
   NSAssert(expectedBuffer.isBinary == buffer.isBinary,
            @"Buffer isBinary should match");
   NSAssert([expectedBuffer.data isEqual:buffer.data],
            @"Buffer data should match");
   [_expectedMessages removeObjectAtIndex:0];
 }
 
 @end