Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1361213002: Adding 20-second timeout to Java and Objective-C tests. (Closed)

Created:
5 years, 3 months ago by Taylor Brandstetter
Modified:
5 years, 2 months ago
Reviewers:
AlexG, jiayl2, tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding 20-second timeout to Java and Objective-C tests. This is the same sort of thing we do in C++ end-to-end PeerConnection tests. Committed: https://crrev.com/4fa648be681ee20d43f79f6c9ec9570631ebcf5a Cr-Commit-Position: refs/heads/master@{#10098}

Patch Set 1 #

Total comments: 16

Patch Set 2 : Use NSTimeInterval instead of int, and constant instead of define. #

Total comments: 4

Patch Set 3 : Minor changes to objc waitForExpectations #

Patch Set 4 : Removing redundant stack trace for timeout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -18 lines) Patch
M talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java View 1 2 3 9 chunks +16 lines, -8 lines 0 comments Download
M talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M talk/app/webrtc/objctests/RTCPeerConnectionTest.mm View 1 6 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
Taylor Brandstetter
5 years, 3 months ago (2015-09-23 20:56:16 UTC) #2
tkchin_webrtc
Also please run against all relevant trybots (iOS+OSX) https://codereview.webrtc.org/1361213002/diff/1/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h File talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h (right): https://codereview.webrtc.org/1361213002/diff/1/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h#newcode58 talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h:58: - ...
5 years, 2 months ago (2015-09-25 15:40:32 UTC) #4
Taylor Brandstetter
Thanks Zeke; as you can tell, I don't write a lot of Objective-C code. :) ...
5 years, 2 months ago (2015-09-25 18:01:58 UTC) #6
AlexG
https://codereview.webrtc.org/1361213002/diff/20001/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java File talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java (right): https://codereview.webrtc.org/1361213002/diff/20001/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java#newcode374 talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java:374: + (new Throwable()).getStackTrace()[1] + "\n for: " Why "[1]" ...
5 years, 2 months ago (2015-09-25 18:49:25 UTC) #7
Taylor Brandstetter
https://codereview.webrtc.org/1361213002/diff/20001/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java File talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java (right): https://codereview.webrtc.org/1361213002/diff/20001/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java#newcode374 talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java:374: + (new Throwable()).getStackTrace()[1] + "\n for: " On 2015/09/25 ...
5 years, 2 months ago (2015-09-25 19:44:03 UTC) #8
tkchin_webrtc
lgtm https://codereview.webrtc.org/1361213002/diff/1/talk/app/webrtc/objctests/RTCPeerConnectionTest.mm File talk/app/webrtc/objctests/RTCPeerConnectionTest.mm (right): https://codereview.webrtc.org/1361213002/diff/1/talk/app/webrtc/objctests/RTCPeerConnectionTest.mm#newcode49 talk/app/webrtc/objctests/RTCPeerConnectionTest.mm:49: #define TIMEOUT_SECONDS 20 On 2015/09/25 18:01:57, Taylor Brandstetter ...
5 years, 2 months ago (2015-09-25 19:51:04 UTC) #9
AlexG
On 2015/09/25 19:44:03, Taylor Brandstetter wrote: > https://codereview.webrtc.org/1361213002/diff/20001/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java > File talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java > (right): > > ...
5 years, 2 months ago (2015-09-25 19:51:51 UTC) #10
Taylor Brandstetter
On 2015/09/25 19:51:51, AlexG wrote: > On 2015/09/25 19:44:03, Taylor Brandstetter wrote: > > > ...
5 years, 2 months ago (2015-09-25 20:15:00 UTC) #11
AlexG
lgtm
5 years, 2 months ago (2015-09-25 20:16:40 UTC) #12
jiayl2
lgtm
5 years, 2 months ago (2015-09-25 20:17:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361213002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361213002/60001
5 years, 2 months ago (2015-09-28 18:07:17 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 2 months ago (2015-09-28 20:07:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361213002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361213002/60001
5 years, 2 months ago (2015-09-28 21:06:45 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-09-28 21:08:57 UTC) #21
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 21:09:14 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4fa648be681ee20d43f79f6c9ec9570631ebcf5a
Cr-Commit-Position: refs/heads/master@{#10098}

Powered by Google App Engine
This is Rietveld 408576698