Adding 20-second timeout to Java and Objective-C tests.

talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m

 /*
  * libjingle
  * Copyright 2013 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 121 matching lines @@
 - (void)expectStateChange:(RTCDataChannelState)state {
   [_expectedStateChanges addObject:@(state)];
 }
 
 - (void)expectMessage:(NSData*)message isBinary:(BOOL)isBinary {
   RTCDataBuffer* buffer = [[RTCDataBuffer alloc] initWithData:message
                                                      isBinary:isBinary];
   [_expectedMessages addObject:buffer];
 }
 
-- (void)waitForAllExpectationsToBeSatisfied {
+- (BOOL)waitForAllExpectationsToBeSatisfiedWithTimeout:(int)timeoutSeconds {
   // TODO (fischman):  Revisit.  Keeping in sync with the Java version, but
   // polling is not optimal.
   // https://code.google.com/p/libjingle/source/browse/trunk/talk/app/webrtc/javatests/src/org/webrtc/PeerConnectionTest.java?line=212#212
+  NSDate *endTime = [NSDate dateWithTimeIntervalSinceNow:timeoutSeconds];

[tkchin_webrtc, 2015/09/25 15:40:32]

Since you are using NSDate API, use NSTimeInterval type for the timeout.

[Taylor Brandstetter, 2015/09/25 18:01:57]

Done.

   while (![self areAllExpectationsSatisfied]) {
+    if ([endTime compare:[NSDate date]] != NSOrderedDescending) {

[tkchin_webrtc, 2015/09/25 15:40:32]

I think it's easier/clearer to use a comparison with timeIntervalSinceNow rather
than calling compare.

[Taylor Brandstetter, 2015/09/25 18:01:57]

Done.

+      return false;

[tkchin_webrtc, 2015/09/25 15:40:32]

return NO;

[Taylor Brandstetter, 2015/09/25 18:01:57]

Done.

+    }
     [[NSRunLoop currentRunLoop]
         runUntilDate:[NSDate dateWithTimeIntervalSinceNow:1]];
   }
+  return true;

[tkchin_webrtc, 2015/09/25 15:40:32]

return YES;

[Taylor Brandstetter, 2015/09/25 18:01:57]

Done.

 }
 
 #pragma mark - RTCPeerConnectionDelegate methods
 
 - (void)peerConnection:(RTCPeerConnection*)peerConnection
     signalingStateChanged:(RTCSignalingState)stateChanged {
   int expectedState = [self popFirstElementAsInt:_expectedSignalingChanges];
   NSString* message =
       [NSString stringWithFormat:@"RTCPeerConnectionDelegate::"
                                  @"onSignalingStateChange [%d] expected[%d]",
@@ skipping 82 matching lines @@
            @"Unexpected message received");
   RTCDataBuffer* expectedBuffer = [_expectedMessages objectAtIndex:0];
   NSAssert(expectedBuffer.isBinary == buffer.isBinary,
            @"Buffer isBinary should match");
   NSAssert([expectedBuffer.data isEqual:buffer.data],
            @"Buffer data should match");
   [_expectedMessages removeObjectAtIndex:0];
 }
 
 @end