Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1356543002: Fix a bug in RtpFileSource related to RTCP packets in rtpdump files (Closed)

Created:
5 years, 3 months ago by hlundin-webrtc
Modified:
5 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a bug in RtpFileSource related to RTCP packets in rtpdump files According to http://www.cs.columbia.edu/irt/software/rtptools/#rtpdump, RTCP packets are marked with plen==0. In this class, plen is mapped to original_length, not length. Committed: https://crrev.com/11d583f41484913fd1e7b3e283966eb7b7e11ed2 Cr-Commit-Position: refs/heads/master@{#9981}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 13 (4 generated)
hlundin-webrtc
5 years, 3 months ago (2015-09-17 09:16:41 UTC) #2
kwiberg-webrtc
lgtm https://codereview.webrtc.org/1356543002/diff/1/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc File webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc (right): https://codereview.webrtc.org/1356543002/diff/1/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc#newcode51 webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc:51: // May be an RTCP packet. Tangent: What ...
5 years, 3 months ago (2015-09-17 10:51:44 UTC) #3
hlundin-webrtc
https://codereview.webrtc.org/1356543002/diff/1/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc File webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc (right): https://codereview.webrtc.org/1356543002/diff/1/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc#newcode51 webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc:51: // May be an RTCP packet. On 2015/09/17 10:51:44, ...
5 years, 3 months ago (2015-09-17 13:33:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356543002/1
5 years, 3 months ago (2015-09-17 13:33:23 UTC) #6
kwiberg-webrtc
https://codereview.webrtc.org/1356543002/diff/1/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc File webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc (right): https://codereview.webrtc.org/1356543002/diff/1/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc#newcode51 webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc:51: // May be an RTCP packet. On 2015/09/17 13:33:07, ...
5 years, 3 months ago (2015-09-17 13:39:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-09-17 15:33:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356543002/1
5 years, 3 months ago (2015-09-18 08:27:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 08:28:10 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 08:28:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11d583f41484913fd1e7b3e283966eb7b7e11ed2
Cr-Commit-Position: refs/heads/master@{#9981}

Powered by Google App Engine
This is Rietveld 408576698