Fix a bug in RtpFileSource related to RTCP packets in rtpdump files

webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 29 matching lines @@
   assert(parser_.get());
   return parser_->RegisterRtpHeaderExtension(type, id);
 }
 
 Packet* RtpFileSource::NextPacket() {
   while (true) {
     RtpPacket temp_packet;
     if (!rtp_reader_->NextPacket(&temp_packet)) {
       return NULL;
     }
-    if (temp_packet.length == 0) {
+    if (temp_packet.original_length == 0) {
       // May be an RTCP packet.

[kwiberg-webrtc, 2015/09/17 10:51:44]

Tangent: What could it be besides an RTCP packet?

[hlundin-webrtc, 2015/09/17 13:33:07]

An RTP packet in disguise? :)

[kwiberg-webrtc, 2015/09/17 13:39:31]

Or a wolf in an RTP packet's clothing?

       // Read the next one.
       continue;
     }
     rtc::scoped_ptr<uint8_t[]> packet_memory(new uint8_t[temp_packet.length]);
     memcpy(packet_memory.get(), temp_packet.data, temp_packet.length);
     rtc::scoped_ptr<Packet> packet(new Packet(
         packet_memory.release(), temp_packet.length,
         temp_packet.original_length, temp_packet.time_ms, *parser_.get()));
     if (!packet->valid_header()) {
       assert(false);
@@ skipping 19 matching lines @@
   rtp_reader_.reset(RtpFileReader::Create(RtpFileReader::kPcap, file_name));
   if (!rtp_reader_) {
     FATAL() << "Couldn't open input file as either a rtpdump or .pcap. Note "
                "that .pcapng is not supported.";
   }
   return true;
 }
 
 }  // namespace test
 }  // namespace webrtc