Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1354933002: Update build files to use webrtc_overrides in Chromium instead of overrides. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell WebRTC
Modified:
5 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update build files to use webrtc_overrides in Chromium instead of overrides. This is a part of moving the overrides to Chromium. See bug comment #65 for all steps. BUG=chromium:468375 Committed: https://crrev.com/baae0a8a6c873ddf812a5687b84638359b2e7e5b Cr-Commit-Position: refs/heads/master@{#9996}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M webrtc/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/base/base.gyp View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/build/common.gypi View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Henrik Grunell WebRTC
5 years, 3 months ago (2015-09-18 14:26:54 UTC) #2
kjellander_webrtc
lgtm + andresp (current sheriff): Please file bug+disable those flaky tests (see trybot runs)
5 years, 3 months ago (2015-09-21 03:56:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354933002/20001
5 years, 3 months ago (2015-09-21 08:45:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 09:53:05 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/baae0a8a6c873ddf812a5687b84638359b2e7e5b Cr-Commit-Position: refs/heads/master@{#9996}
5 years, 3 months ago (2015-09-21 09:53:15 UTC) #8
Henrik Grunell WebRTC
5 years, 3 months ago (2015-09-21 10:29:18 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1352423002/ by henrikg@webrtc.org.

The reason for reverting is: Breaks FYI bots.

ninja: error: '../../third_party/webrtc_overrides/webrtc/base/logging.cc',
needed by 'obj/third_party/webrtc_overrides/webrtc/base/rtc_base.logging.o',
missing and no known rule to make it
.

Powered by Google App Engine
This is Rietveld 408576698