Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1350393003: Remove overrides folder. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell WebRTC
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@update_overrides_in_build_files
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove overrides folder. This is a part of moving the overrides to Chromium. See bug comment #65 for all steps. Depends on https://codereview.chromium.org/1357913002/ BUG=chromium:468375 TBR=tommi@webrtc.org Committed: https://crrev.com/4a8e9c556af602ad6860df7d23247d0e2efe0cc2 Cr-Commit-Position: refs/heads/master@{#10117}

Patch Set 1 #

Patch Set 2 : Updated DEPS. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -678 lines) Patch
M DEPS View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/overrides/OWNERS View 1 chunk +0 lines, -12 lines 0 comments Download
D webrtc/overrides/webrtc/base/diagnostic_logging.h View 1 chunk +0 lines, -157 lines 0 comments Download
D webrtc/overrides/webrtc/base/logging.h View 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/overrides/webrtc/base/logging.cc View 1 chunk +0 lines, -378 lines 0 comments Download
D webrtc/overrides/webrtc/base/win32socketinit.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
Henrik Grunell WebRTC
Henrik K: has the big picture. Per: as owner of the removed folder.
5 years, 3 months ago (2015-09-21 11:04:07 UTC) #2
kjellander_webrtc
lgtm
5 years, 3 months ago (2015-09-21 12:41:26 UTC) #3
perkj_webrtc
On 2015/09/21 12:41:26, kjellander (webrtc) wrote: > lgtm rs lgtm
5 years, 3 months ago (2015-09-24 07:29:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350393003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350393003/40001
5 years, 2 months ago (2015-09-30 14:57:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1021)
5 years, 2 months ago (2015-09-30 14:58:35 UTC) #9
Henrik Grunell WebRTC
The presubmit script couldn't identify Per as owner of the removed files since, I guess, ...
5 years, 2 months ago (2015-09-30 15:08:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350393003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350393003/40001
5 years, 2 months ago (2015-09-30 15:08:48 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-30 15:10:00 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 15:14:35 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4a8e9c556af602ad6860df7d23247d0e2efe0cc2
Cr-Commit-Position: refs/heads/master@{#10117}

Powered by Google App Engine
This is Rietveld 408576698