Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1345313004: Update build files to use webrtc_overrides in Chromium instead of overrides. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell WebRTC
Modified:
5 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update build files to use webrtc_overrides in Chromium instead of overrides. This re-lands https://codereview.webrtc.org/1354933002/ This is a part of moving the overrides to Chromium. See bug comment #65 for all steps. Depends on https://codereview.chromium.org/1345873004/ BUG=chromium:468375 Committed: https://crrev.com/ee2bf41a79b9bf44aa1658d2d491577ae440334e Cr-Commit-Position: refs/heads/master@{#10115}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/base/base.gyp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/build/common.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Henrik Grunell WebRTC
5 years, 3 months ago (2015-09-21 10:55:27 UTC) #2
kjellander_webrtc
lgtm
5 years, 3 months ago (2015-09-21 12:42:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345313004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345313004/20001
5 years, 2 months ago (2015-09-30 10:00:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 10:48:58 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 10:49:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee2bf41a79b9bf44aa1658d2d491577ae440334e
Cr-Commit-Position: refs/heads/master@{#10115}

Powered by Google App Engine
This is Rietveld 408576698