Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1354683004: Remove camera.setPreviewTexture in doStopCaptureOnCameraThread. (Closed)

Created:
5 years, 3 months ago by perkj_webrtc
Modified:
5 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes camera.setPreviewTexture in doStopCaptureOnCameraThread and removes the try catch statement since the only method throwing an exception was setPreviewTexture. BUG=webrtc:5003 R=magjed@webrtc.org Committed: https://crrev.com/3520f9e0493b106d71cae3ee67108e00af13f1f7 Cr-Commit-Position: refs/heads/master@{#9985}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 2 4 chunks +16 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_webrtc
Is there a bug number I should add?
5 years, 3 months ago (2015-09-17 19:54:57 UTC) #3
magjed_webrtc
lgtm
5 years, 3 months ago (2015-09-18 08:45:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354683004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354683004/60001
5 years, 3 months ago (2015-09-18 08:45:56 UTC) #6
perkj_webrtc
Committed patchset #3 (id:60001) manually as 3520f9e0493b106d71cae3ee67108e00af13f1f7 (presubmit successful).
5 years, 3 months ago (2015-09-18 09:53:05 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 09:53:06 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3520f9e0493b106d71cae3ee67108e00af13f1f7
Cr-Commit-Position: refs/heads/master@{#9985}

Powered by Google App Engine
This is Rietveld 408576698