Adding support for simulcast and spatial layers into VideoQualityTest

Adding support for simulcast and spatial layers into VideoQualityTest

The CL includes several changes:
- Adding flags describing the streams and spatial layers.
- Reorganizing the order of the flags, to make them easier to maintain.
- Adding a member .params_ to VideoQualityAnalyzer.
    (instead of passing it to every member function manually)
- Updating VideoAnalyzer to support simulcast.
    (select appropriate ssrc and fix timestamps which are sometimes increased by 1)
- VP9EncoderImpl already had code for automatic calculation of bitrate for each layer.
    Changing to first read bitrates and resolution ratios from the flags, if specified.
    If not specified, reverting to the old code are setting the values automatically.
- Changing the parameters in LayerFilteringTransport, replacing
    xx_discard_thresholds with selected_xx, to make it easier to use for the end user.

Committed: https://crrev.com/87f83a9a27d657731ccb54025bc04ccad0da136e
Cr-Commit-Position: refs/heads/master@{#10215}

[ivica, 2015-09-22 16:21:04]

ivica@webrtc.org changed reviewers:
+ pbos@webrtc.org, sprang@webrtc.org

[ivica, 2015-09-22 16:21:05]

https://codereview.webrtc.org/1353263005/diff/1/webrtc/test/layer_filtering_t...
File webrtc/test/layer_filtering_transport.cc (right):

https://codereview.webrtc.org/1353263005/diff/1/webrtc/test/layer_filtering_t...
webrtc/test/layer_filtering_transport.cc:40: uint16_t
LayerFilteringTransport::NextSequenceNumber(uint32_t ssrc) {
Including the patch https://codereview.webrtc.org/1350383004/

[sprang_webrtc, 2015-09-29 14:19:33]

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/common_types.h#new...
webrtc/common_types.h:563: enum { kMaxTemporalStreams = 4};
Can we make these all static const int?
These don't make sense as enums...

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/common_types.h#new...
webrtc/common_types.h:698: // int max_quantizer;
If you don't include them in this CL, but you think it should be later, just add
a todo to that affect. Don't add commented out code.

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:174: LOG(LS_ERROR) <<
"Unsupported number of temporal layers!";
LOG(LS_ERROR) << "Unsupported number of temporal layers: " <<
num_temporal_layers_;

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:176: }
Why not switch?

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:332: // TODO(ivica): Will this work for > 2
streams?
No, right? :)
Just change it to something like
// TODO(ivica): Make this work with > 2 streams.

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:661: sscanf(p, "%d%n", &value, &pos);
Do you need to detect error from string->int parsing?

[pbos-webrtc, 2015-09-29 14:38:46]

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/common_types.h#new...
webrtc/common_types.h:563: enum { kMaxTemporalStreams = 4};
On 2015/09/29 14:19:33, språng wrote:
> Can we make these all static const int?
> These don't make sense as enums...

I think that'll potentially cause linker errors (unless in anonymous
namespaces). Woo.

[ivica, 2015-09-29 15:14:51]

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/common_types.h#new...
webrtc/common_types.h:563: enum { kMaxTemporalStreams = 4};
On 2015/09/29 14:38:46, pbos-webrtc wrote:
> On 2015/09/29 14:19:33, språng wrote:
> > Can we make these all static const int?
> > These don't make sense as enums...
> 
> I think that'll potentially cause linker errors (unless in anonymous
> namespaces). Woo.

Probably better just to keep them as compile-time constants. Otherwise I would
have to add extern or who knows what.

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/common_types.h#new...
webrtc/common_types.h:698: // int max_quantizer;
On 2015/09/29 14:19:33, språng wrote:
> If you don't include them in this CL, but you think it should be later, just
add
> a todo to that affect. Don't add commented out code.

Removed commented out code.

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:174: LOG(LS_ERROR) <<
"Unsupported number of temporal layers!";
On 2015/09/29 14:19:33, språng wrote:
> LOG(LS_ERROR) << "Unsupported number of temporal layers: " <<
> num_temporal_layers_;

Done.

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:176: }
On 2015/09/29 14:19:33, språng wrote:
> Why not switch?

This is not my code, should I change it?

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:332: // TODO(ivica): Will this work for > 2
streams?
On 2015/09/29 14:19:33, språng wrote:
> No, right? :)
> Just change it to something like
> // TODO(ivica): Make this work with > 2 streams.

Done.

https://codereview.webrtc.org/1353263005/diff/20001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:661: sscanf(p, "%d%n", &value, &pos);
On 2015/09/29 14:19:33, språng wrote:
> Do you need to detect error from string->int parsing?

Added a RTC_CHECK_EQ to 1.

[ivica, 2015-09-30 12:39:21]

The CQ bit was checked by ivica@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-30 12:39:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353263005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353263005/60001

[commit-bot: I haz the power, 2015-09-30 12:42:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 12:42:12]

Dry run: Try jobs failed on following builders:
  win_x64_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_dbg/builds/4298)

[sprang_webrtc, 2015-10-05 11:14:40]

Some minor comments.
Looks like you need a rebase :)

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.h (right):

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:59: bool
ManuallyConfiguringSpatialLayers() const;
Would like a better name. Perhaps ExplicitlyConfiguredSpatialLayers() ?

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:653: int value = -1, pos;
Declare separately.

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:974: sprintf(title, "Loopback Video - Stream
#%" PRIuS, stream_id);
Braces, like so:
if () {
  ...
} else {
  ...
}

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.h (right):

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.h:21: #define AUTO_GRAPH_TITLE    "__AUTO__"
Not sure about this. You're using this just to get something hopefully unique,
that indicates that a graph title should be auto-generated?
Can't you just use the empty string for this? Preferably define a constant named
such that it's clear what's intended from the place of usage. Also comment at
the definition.

[ivica, 2015-10-05 12:11:04]

The CQ bit was checked by ivica@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-05 12:11:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353263005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353263005/80001

[ivica, 2015-10-05 12:11:17]

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.h (right):

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:59: bool
ManuallyConfiguringSpatialLayers() const;
On 2015/10/05 11:14:40, språng wrote:
> Would like a better name. Perhaps ExplicitlyConfiguredSpatialLayers() ?

Yeah, that sounds better. Renamed.

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:653: int value = -1, pos;
On 2015/10/05 11:14:40, språng wrote:
> Declare separately.

Done.

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:974: sprintf(title, "Loopback Video - Stream
#%" PRIuS, stream_id);
On 2015/10/05 11:14:40, språng wrote:
> Braces, like so:
> if () {
>   ...
> } else {
>   ...
> }

Done.

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.h (right):

https://codereview.webrtc.org/1353263005/diff/60001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.h:21: #define AUTO_GRAPH_TITLE    "__AUTO__"
On 2015/10/05 11:14:40, språng wrote:
> Not sure about this. You're using this just to get something hopefully unique,
> that indicates that a graph title should be auto-generated?
> Can't you just use the empty string for this? Preferably define a constant
named
> such that it's clear what's intended from the place of usage. Also comment at
> the definition.

You are right, this is unnecessary. Probably no one wants an empty title. I've
just removed this macro and instead do a check if the graph_title is empty.

[commit-bot: I haz the power, 2015-10-05 12:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 12:14:38]

Dry run: Try jobs failed on following builders:
  mac_x64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_rel/builds/9614)

[ivica, 2015-10-05 13:18:14]

The CQ bit was checked by ivica@webrtc.org

[commit-bot: I haz the power, 2015-10-05 13:18:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353263005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353263005/120001

[commit-bot: I haz the power, 2015-10-05 13:18:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 13:18:25]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[ivica, 2015-10-05 13:18:27]

The CQ bit was unchecked by ivica@webrtc.org

[ivica, 2015-10-05 13:20:06]

The CQ bit was checked by ivica@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-05 13:20:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353263005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353263005/120001

[ivica, 2015-10-05 13:20:16]

ivica@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[ivica, 2015-10-05 13:20:17]

+mflodman

[commit-bot: I haz the power, 2015-10-05 15:20:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 15:20:47]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[sprang_webrtc, 2015-10-06 09:28:59]

lgtm
pbos@, ptal

[mflodman, 2015-10-06 11:27:28]

Functionality LG!

A few comments.

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/common_types.h#ne...
webrtc/common_types.h:714: SpatialLayer        spatialLayers[kMaxSpatialLayers];
I know this is following the previous style, but I'd stil prefer to use an
std::vector here instead. But feel free to skip this comment in case that
introduces lots of extra work, I know the code depending on this type of
structure in a few places.

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:127: LOG(LS_ERROR) << "When
specifying spatial layers manually, "
Is this due to libvpx implementation?

If so, please add "by libvpx" to the error log.

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.h (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:59: bool
ExplicitlyConfiguredSpatialLayers() const;
Are there cases we configure spatial layers implicitly and want to do things
differently? If not, can we name it something shorter like
'SpatialLayersConfigured()', 'UsingSpatialLayers()' or similar?

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/test/layer_filter...
File webrtc/test/layer_filtering_transport.h (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/test/layer_filter...
webrtc/test/layer_filtering_transport.h:44: std::map<uint32_t, uint16_t>
current_seq_nums_;
Add a comment for the map key.

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/video/video_send_...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/video/video_send_...
webrtc/video/video_send_stream.cc:318: RTC_DCHECK_LE(streams.size(),
static_cast<size_t>(kMaxSimulcastStreams));
Add a similar check for config.spatial_layers.size().

[ivica, 2015-10-06 13:37:24]

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/common_types.h#ne...
webrtc/common_types.h:714: SpatialLayer        spatialLayers[kMaxSpatialLayers];
On 2015/10/06 11:27:27, mflodman wrote:
> I know this is following the previous style, but I'd stil prefer to use an
> std::vector here instead. But feel free to skip this comment in case that
> introduces lots of extra work, I know the code depending on this type of
> structure in a few places.

It turns out there is a bunch of memcpy calls that copy VideoCodec from one
place to another. Should I replace them with "x = y" and hope I don't break
anything, or just leave C-style array?

[mflodman, 2015-10-07 11:23:06]

On 2015/10/06 13:37:24, ivica wrote:
> https://codereview.webrtc.org/1353263005/diff/120001/webrtc/common_types.h
> File webrtc/common_types.h (right):
> 
>
https://codereview.webrtc.org/1353263005/diff/120001/webrtc/common_types.h#ne...
> webrtc/common_types.h:714: SpatialLayer       
spatialLayers[kMaxSpatialLayers];
> On 2015/10/06 11:27:27, mflodman wrote:
> > I know this is following the previous style, but I'd stil prefer to use an
> > std::vector here instead. But feel free to skip this comment in case that
> > introduces lots of extra work, I know the code depending on this type of
> > structure in a few places.
> 
> It turns out there is a bunch of memcpy calls that copy VideoCodec from one
> place to another. Should I replace them with "x = y" and hope I don't break
> anything, or just leave C-style array?

Ack.

[mflodman, 2015-10-07 11:23:43]

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/common_types.h#ne...
webrtc/common_types.h:714: SpatialLayer        spatialLayers[kMaxSpatialLayers];
On 2015/10/06 13:37:24, ivica wrote:
> On 2015/10/06 11:27:27, mflodman wrote:
> > I know this is following the previous style, but I'd stil prefer to use an
> > std::vector here instead. But feel free to skip this comment in case that
> > introduces lots of extra work, I know the code depending on this type of
> > structure in a few places.
> 
> It turns out there is a bunch of memcpy calls that copy VideoCodec from one
> place to another. Should I replace them with "x = y" and hope I don't break
> anything, or just leave C-style array?

Then let's keep it for now and we'll take care of it when fixing
'simulcastStream;.

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:127: LOG(LS_ERROR) << "When
specifying spatial layers manually, "
On 2015/10/06 11:27:27, mflodman wrote:
> Is this due to libvpx implementation?
> 
> If so, please add "by libvpx" to the error log.

Ping.

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.h (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:59: bool
ExplicitlyConfiguredSpatialLayers() const;
On 2015/10/06 11:27:27, mflodman wrote:
> Are there cases we configure spatial layers implicitly and want to do things
> differently? If not, can we name it something shorter like
> 'SpatialLayersConfigured()', 'UsingSpatialLayers()' or similar?

Ping.

[ivica, 2015-10-07 11:59:50]

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:127: LOG(LS_ERROR) << "When
specifying spatial layers manually, "
On 2015/10/07 11:23:43, mflodman wrote:
> On 2015/10/06 11:27:27, mflodman wrote:
> > Is this due to libvpx implementation?
> > 
> > If so, please add "by libvpx" to the error log.
> 
> Ping.

The comment was confusing, changed it. Libvpx does support it, just there is no
way to specify manually bitrates for temporal layers. (my patch implemented only
the 1 TL case, as that was the only thing I needed)

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.h (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:59: bool
ExplicitlyConfiguredSpatialLayers() const;
On 2015/10/07 11:23:43, mflodman wrote:
> On 2015/10/06 11:27:27, mflodman wrote:
> > Are there cases we configure spatial layers implicitly and want to do things
> > differently? If not, can we name it something shorter like
> > 'SpatialLayersConfigured()', 'UsingSpatialLayers()' or similar?
> 
> Ping.

The manual configuration is currently used only from loopback tests currently,
where you specify bitrates directly via command line args. The other way is just
to let VP9Impl calculate them for you (it takes into account layer resolutions
and similar).
Because spatialLayers is not a std::vector, but a C-style array, I have to do
magic to detect if the user wants to manually specify bitrates. That's why I
created this helper method.
'UsingSpatialLayers()' wouldn't fit the usage, but 'SpatialLayersConfigued()'
might in some sense, but still not perfectly.

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/test/layer_filter...
File webrtc/test/layer_filtering_transport.h (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/test/layer_filter...
webrtc/test/layer_filtering_transport.h:44: std::map<uint32_t, uint16_t>
current_seq_nums_;
On 2015/10/06 11:27:27, mflodman wrote:
> Add a comment for the map key.

Done.

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/video/video_send_...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/video/video_send_...
webrtc/video/video_send_stream.cc:318: RTC_DCHECK_LE(streams.size(),
static_cast<size_t>(kMaxSimulcastStreams));
On 2015/10/06 11:27:27, mflodman wrote:
> Add a similar check for config.spatial_layers.size().

Done.

[mflodman, 2015-10-08 09:11:36]

LGTM

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1353263005/diff/120001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:127: LOG(LS_ERROR) << "When
specifying spatial layers manually, "
On 2015/10/07 11:59:50, ivica wrote:
> On 2015/10/07 11:23:43, mflodman wrote:
> > On 2015/10/06 11:27:27, mflodman wrote:
> > > Is this due to libvpx implementation?
> > > 
> > > If so, please add "by libvpx" to the error log.
> > 
> > Ping.
> 
> The comment was confusing, changed it. Libvpx does support it, just there is
no
> way to specify manually bitrates for temporal layers. (my patch implemented
only
> the 1 TL case, as that was the only thing I needed)

Great, LG!

[ivica, 2015-10-08 09:16:25]

The CQ bit was checked by ivica@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-08 09:16:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353263005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353263005/160001

[commit-bot: I haz the power, 2015-10-08 10:00:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 10:00:40]

Dry run: This issue passed the CQ dry run.

[ivica, 2015-10-08 11:27:12]

The CQ bit was checked by ivica@webrtc.org

[ivica, 2015-10-08 11:27:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1353263005/#ps160001 (title:
"rebase master")

[ivica, 2015-10-08 11:27:20]

The CQ bit was unchecked by ivica@webrtc.org

[ivica, 2015-10-08 11:28:52]

The CQ bit was checked by ivica@webrtc.org

[ivica, 2015-10-08 11:28:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org,
mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1353263005/#ps180001 (title:
"rebase master, includes the perf regression fix")

[commit-bot: I haz the power, 2015-10-08 11:29:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353263005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353263005/180001

[commit-bot: I haz the power, 2015-10-08 12:13:37]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-10-08 12:13:46]

Patchset 10 (id:??) landed as
https://crrev.com/87f83a9a27d657731ccb54025bc04ccad0da136e
Cr-Commit-Position: refs/heads/master@{#10215}

[sprang_webrtc, 2015-10-12 13:33:03]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.webrtc.org/1397363002/ by sprang@webrtc.org.

The reason for reverting is: Temporarily reverting as this causes some issues
with perf tests. Especially tests with packet loss no longer works..