Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1350383004: Using different sequence numbers for different SSRCs (Closed)

Created:
5 years, 3 months ago by ivica
Modified:
5 years, 2 months ago
Reviewers:
sprang_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Using different sequence numbers for different SSRCs This seems to solve the unexpected behavior when selecting lower layers. Also, this replaces https://codereview.webrtc.org/1327153002/ Committed: https://crrev.com/e78e2c714bdbecb910526746d9e3678a245a8f8b Cr-Commit-Position: refs/heads/master@{#10206}

Patch Set 1 #

Patch Set 2 : Replacing payload_type with ssrc #

Total comments: 4

Patch Set 3 : Addressing comments #

Patch Set 4 : rebase master #

Patch Set 5 : Adding a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M webrtc/test/layer_filtering_transport.h View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M webrtc/test/layer_filtering_transport.cc View 1 2 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
ivica
5 years, 3 months ago (2015-09-22 12:50:49 UTC) #2
sprang_webrtc
Looks good. Perhaps you should add a unit test as well? https://codereview.webrtc.org/1350383004/diff/20001/webrtc/test/layer_filtering_transport.cc File webrtc/test/layer_filtering_transport.cc (right): ...
5 years, 3 months ago (2015-09-23 13:58:19 UTC) #3
mflodman
LGTM with Erik's comments addressed.
5 years, 2 months ago (2015-10-02 09:08:37 UTC) #4
ivica
Unit tests would require simulating packets and catching them, which seems to be unexpectedly difficult. ...
5 years, 2 months ago (2015-10-07 12:07:42 UTC) #5
sprang_webrtc
lgtm
5 years, 2 months ago (2015-10-07 13:50:46 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350383004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350383004/80001
5 years, 2 months ago (2015-10-07 14:04:07 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 14:59:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350383004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350383004/80001
5 years, 2 months ago (2015-10-08 06:43:19 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-08 06:44:35 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 06:44:46 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e78e2c714bdbecb910526746d9e3678a245a8f8b
Cr-Commit-Position: refs/heads/master@{#10206}

Powered by Google App Engine
This is Rietveld 408576698