Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1351503004: Purge nss files and dependencies. (Closed)

Created:
5 years, 2 months ago by torbjorng (webrtc)
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Purge nss files and dependencies. This replaces https://codereview.webrtc.org/1313233005 which was reverted after triggering Chromium issues. The only difference is that we're cleaned up dependencies on use_openssl from the gyp file. Since https://codereview.chromium.org/1358913003 landed, this CL should cause no Chromium issues. BUG=webrtc:4497 Committed: https://crrev.com/07d09364b003e6738a02d9940aebab5d3814da6d Cr-Commit-Position: refs/heads/master@{#10019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2240 lines) Patch
M talk/media/sctp/sctpdataengine_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/base/BUILD.gn View 3 chunks +0 lines, -42 lines 0 comments Download
M webrtc/base/base.gyp View 5 chunks +22 lines, -79 lines 0 comments Download
M webrtc/base/helpers.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D webrtc/base/nssidentity.h View 1 chunk +0 lines, -143 lines 0 comments Download
D webrtc/base/nssidentity.cc View 1 chunk +0 lines, -581 lines 0 comments Download
D webrtc/base/nssstreamadapter.h View 1 chunk +0 lines, -125 lines 0 comments Download
D webrtc/base/nssstreamadapter.cc View 1 chunk +0 lines, -1127 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/ssladapter.cc View 3 chunks +3 lines, -21 lines 0 comments Download
M webrtc/base/sslconfig.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/base/sslidentity.cc View 2 chunks +1 line, -25 lines 0 comments Download
M webrtc/base/sslidentity_unittest.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 3 chunks +3 lines, -23 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/base/sslstreamadapterhelper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/sanitizers/lsan_suppressions_webrtc.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351503004/1
5 years, 2 months ago (2015-09-22 15:00:53 UTC) #2
torbjorng (webrtc)
PTAL, tommi.
5 years, 2 months ago (2015-09-22 15:47:25 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
5 years, 2 months ago (2015-09-22 17:01:00 UTC) #6
tommi
lgtm
5 years, 2 months ago (2015-09-22 17:02:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351503004/1
5 years, 2 months ago (2015-09-22 17:02:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-22 18:58:09 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-22 18:58:25 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/07d09364b003e6738a02d9940aebab5d3814da6d
Cr-Commit-Position: refs/heads/master@{#10019}

Powered by Google App Engine
This is Rietveld 408576698