purge nss files and dependencies

purge nss files and dependencies

BUG=webrtc:4497
Committed: https://crrev.com/5647a2cf3db888195c928a1259d98f72f6ecbc15
Cr-Commit-Position: refs/heads/master@{#9862}

[torbjorng (webrtc), 2015-09-04 10:18:08]

The CQ bit was checked by torbjorng@webrtc.org to run a CQ dry run

[torbjorng (webrtc), 2015-09-04 10:18:17]

The CQ bit was unchecked by torbjorng@webrtc.org

[commit-bot: I haz the power, 2015-09-04 10:18:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1313233005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1313233005/1

[torbjorng (webrtc), 2015-09-04 11:50:42]

torbjorng@webrtc.org changed reviewers:
+ kjellander@webrtc.org, tommi@webrtc.org

[torbjorng (webrtc), 2015-09-04 11:54:06]

PTAL tommi and kjellander!

This CL removes NSS legacy files and its dependencies.

Not done: The use_openssl gyp/gn variable could be
eliminated from WebRTC (but not Chrome) build files
since it is always 1. Now it is still tested, but if
it is 0 the build will not link.

[kjellander_webrtc, 2015-09-04 12:18:18]

On 2015/09/04 11:54:06, torbjorng1 wrote:
> PTAL tommi and kjellander!
>
> This CL removes NSS legacy files and its dependencies.

lgtm. Great to get this cleaned up.
 
> Not done: The use_openssl gyp/gn variable could be
> eliminated from WebRTC (but not Chrome) build files
> since it is always 1. Now it is still tested, but if
> it is 0 the build will not link.

What kind of error do you get if you remove it? Sounds strange to me. 
If you remove the variable and all conditions using it in GYP (since it's always
1) the resulting generated ninja files should be identical, thus link fine.

[torbjorng (webrtc), 2015-09-04 13:18:18]

> > Not done: The use_openssl gyp/gn variable could be
> > eliminated from WebRTC (but not Chrome) build files
> > since it is always 1. Now it is still tested, but if
> > it is 0 the build will not link.
> 
> What kind of error do you get if you remove it? Sounds strange to me. 
> If you remove the variable and all conditions using it in GYP (since it's
always
> 1) the resulting generated ninja files should be identical, thus link fine.

Removing it would be possible, and should cause no harm.  Setting it to 0 will
suppress inclusion of some files which will now be unconditionally needed,
thus cause link errors.

We might want to remove it, but keeping it suggests that it is a "module" which
might be supplanted with alternatives some day (e.g., the faster GnuTLS).

Keeping the variable at least until Chrome is Open/BoringSSL-only would be good
IMO, since it has the "same" variable.  I don't have a strong opinion.

[kjellander_webrtc, 2015-09-04 13:26:20]

On 2015/09/04 13:18:18, torbjorng1 wrote:
> > > Not done: The use_openssl gyp/gn variable could be
> > > eliminated from WebRTC (but not Chrome) build files
> > > since it is always 1. Now it is still tested, but if
> > > it is 0 the build will not link.
> > 
> > What kind of error do you get if you remove it? Sounds strange to me. 
> > If you remove the variable and all conditions using it in GYP (since it's
> always
> > 1) the resulting generated ninja files should be identical, thus link fine.
> 
> Removing it would be possible, and should cause no harm.  Setting it to 0 will
> suppress inclusion of some files which will now be unconditionally needed,
> thus cause link errors.

Ah, I didn't get that you meant you got link errors if you set it to 0 :)
 
> We might want to remove it, but keeping it suggests that it is a "module"
which
> might be supplanted with alternatives some day (e.g., the faster GnuTLS).
> 
> Keeping the variable at least until Chrome is Open/BoringSSL-only would be
good
> IMO, since it has the "same" variable.  I don't have a strong opinion.

Then I suggest we keep it around.

[tommi, 2015-09-04 13:40:24]

lgtm!

[torbjorng (webrtc), 2015-09-04 13:56:27]

The CQ bit was checked by torbjorng@webrtc.org

[commit-bot: I haz the power, 2015-09-04 13:56:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1313233005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1313233005/1

[commit-bot: I haz the power, 2015-09-04 15:11:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-04 15:12:06]

Patchset 1 (id:??) landed as
https://crrev.com/5647a2cf3db888195c928a1259d98f72f6ecbc15
Cr-Commit-Position: refs/heads/master@{#9862}

[Taylor Brandstetter, 2015-09-04 23:01:36]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1311843006/ by deadbeef@webrtc.org.

The reason for reverting is: It looks like this broke the FYI bots. I tried
updating libjingle_nacl.gyp, but the IOS build still failed because in Chrome
it's configured to use NSS. See https://codereview.chromium.org/1316863012/..