Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(51)

Issue 1313233005: purge nss files and dependencies (Closed)

Created:
4 years, 1 month ago by torbjorng (webrtc)
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

purge nss files and dependencies BUG=webrtc:4497 Committed: https://crrev.com/5647a2cf3db888195c928a1259d98f72f6ecbc15 Cr-Commit-Position: refs/heads/master@{#9862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2206 lines) Patch
M talk/media/sctp/sctpdataengine_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/base/BUILD.gn View 3 chunks +0 lines, -42 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
M webrtc/base/helpers.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D webrtc/base/nssidentity.h View 1 chunk +0 lines, -143 lines 0 comments Download
D webrtc/base/nssidentity.cc View 1 chunk +0 lines, -581 lines 0 comments Download
D webrtc/base/nssstreamadapter.h View 1 chunk +0 lines, -125 lines 0 comments Download
D webrtc/base/nssstreamadapter.cc View 1 chunk +0 lines, -1127 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/ssladapter.cc View 3 chunks +3 lines, -21 lines 0 comments Download
M webrtc/base/sslconfig.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/base/sslidentity.cc View 2 chunks +1 line, -25 lines 0 comments Download
M webrtc/base/sslidentity_unittest.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 3 chunks +3 lines, -23 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/base/sslstreamadapterhelper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/sanitizers/lsan_suppressions_webrtc.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313233005/1
4 years, 1 month ago (2015-09-04 10:18:19 UTC) #3
torbjorng (webrtc)
PTAL tommi and kjellander! This CL removes NSS legacy files and its dependencies. Not done: ...
4 years, 1 month ago (2015-09-04 11:54:06 UTC) #5
kjellander_webrtc
On 2015/09/04 11:54:06, torbjorng1 wrote: > PTAL tommi and kjellander! > > This CL removes ...
4 years, 1 month ago (2015-09-04 12:18:18 UTC) #6
torbjorng (webrtc)
> > Not done: The use_openssl gyp/gn variable could be > > eliminated from WebRTC ...
4 years, 1 month ago (2015-09-04 13:18:18 UTC) #7
kjellander_webrtc
On 2015/09/04 13:18:18, torbjorng1 wrote: > > > Not done: The use_openssl gyp/gn variable could ...
4 years, 1 month ago (2015-09-04 13:26:20 UTC) #8
tommi
lgtm!
4 years, 1 month ago (2015-09-04 13:40:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313233005/1
4 years, 1 month ago (2015-09-04 13:56:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2015-09-04 15:11:55 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5647a2cf3db888195c928a1259d98f72f6ecbc15 Cr-Commit-Position: refs/heads/master@{#9862}
4 years, 1 month ago (2015-09-04 15:12:06 UTC) #13
Taylor Brandstetter
4 years, 1 month ago (2015-09-04 23:01:36 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1311843006/ by deadbeef@webrtc.org.

The reason for reverting is: It looks like this broke the FYI bots. I tried
updating libjingle_nacl.gyp, but the IOS build still failed because in Chrome
it's configured to use NSS. See https://codereview.chromium.org/1316863012/..

Powered by Google App Engine
This is Rietveld 408576698