Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1349433003: Re-add SurfaceTexture as member for setLocalPreview in VideoCapturerAndroid. (Closed)

Created:
5 years, 3 months ago by perkj_webrtc
Modified:
5 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-add SurfaceTexture as member for setLocalPreview in VideoCapturerAndroid. The Android camera api requires a surface to be set in order work. In https://codereview.webrtc.org/1354683004/ this surfaceTexture was removed as a member but it turns out that can lead to camera freezes when the device is rotated. This cl re-adds the surface as a member. BUG=webrtc:5021, webrtc:5003 R=magjed@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/e6d3adab087281c24076a534b1c82e47e60153bd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 3 chunks +4 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
perkj_webrtc
Please?
5 years, 3 months ago (2015-09-21 11:45:22 UTC) #2
magjed_webrtc
lgtm https://codereview.webrtc.org/1349433003/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/1349433003/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java#newcode80 talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:80: private SurfaceTexture cameraSurfaceTexture; This is very strange. I ...
5 years, 3 months ago (2015-09-21 11:55:32 UTC) #3
perkj_webrtc
Committed patchset #1 (id:1) manually as e6d3adab087281c24076a534b1c82e47e60153bd (presubmit successful).
5 years, 3 months ago (2015-09-21 11:58:00 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 11:58:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6d3adab087281c24076a534b1c82e47e60153bd
Cr-Commit-Position: refs/heads/master@{#9999}

Powered by Google App Engine
This is Rietveld 408576698