Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348613003: Move AudioDecoderPcm* next to AudioEncoderPcm* (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@dmove-pcm16
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move AudioDecoderPcm* next to AudioEncoderPcm* All AudioDecoder subclasses have historically lived in NetEq, but they fit better with the codec they wrap. BUG=webrtc:4557 Committed: https://crrev.com/6faf5bebbab70fd358364b901e36c236bbe84046 Cr-Commit-Position: refs/heads/master@{#10015}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -123 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.cc View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/g711.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/g711/include/audio_decoder_pcm.h View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 1 2 2 chunks +1 line, -61 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1339253003 Patch 120001

Messages

Total messages: 16 (7 generated)
kwiberg-webrtc
5 years, 3 months ago (2015-09-17 05:57:41 UTC) #2
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-22 09:11:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348613003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348613003/40001
5 years, 3 months ago (2015-09-22 09:43:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/4066)
5 years, 3 months ago (2015-09-22 10:06:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348613003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348613003/40001
5 years, 3 months ago (2015-09-22 11:39:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 3 months ago (2015-09-22 11:43:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348613003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348613003/40001
5 years, 3 months ago (2015-09-22 12:06:33 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-22 13:16:56 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 13:17:03 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6faf5bebbab70fd358364b901e36c236bbe84046
Cr-Commit-Position: refs/heads/master@{#10015}

Powered by Google App Engine
This is Rietveld 408576698