Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1339253003: Move AudioDecoderIsac* to its own files (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move AudioDecoderIsac* to its own files Currently, it's sitting in AudioEncoderIsac*'s files, which is less than obvious. This CL puts the encoder and decoder in separate files together with the C implementation; CLs are afoot to make it so for the other built-in codecs as well. BUG=webrtc:4557 R=henrik.lundin@webrtc.org Committed: https://crrev.com/740436899825b96e12469c417c0ea82fd8a22edf Cr-Commit-Position: refs/heads/master@{#10018}

Patch Set 1 #

Patch Set 2 : compile fix #

Patch Set 3 : test #

Patch Set 4 : rebase #

Patch Set 5 : try enum hack #

Patch Set 6 : rebase #

Total comments: 1

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -373 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 3 4 5 6 4 chunks +6 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/isac/audio_decoder_isac_t.h View 1 2 3 4 5 1 chunk +53 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/isac/audio_decoder_isac_t_impl.h View 1 2 3 4 5 6 1 chunk +108 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 2 3 4 5 2 chunks +0 lines, -32 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 2 3 4 5 6 2 chunks +0 lines, -89 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/isac/fix/interface/audio_decoder_isacfix.h View 1 chunk +22 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/interface/audio_encoder_isacfix.h View 1 2 3 4 5 6 1 chunk +1 line, -105 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/fix/source/audio_decoder_isacfix.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/audio_encoder_isacfix.cc View 1 chunk +0 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/fix/source/isac_fix_type.h View 1 2 3 4 5 6 4 chunks +12 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isac.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isacfix.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/isac/main/interface/audio_decoder_isac.h View 1 chunk +22 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/interface/audio_encoder_isac.h View 1 chunk +1 line, -103 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/main/source/audio_decoder_isac.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/main/source/isac_float_type.h View 4 chunks +8 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kwiberg-webrtc
https://codereview.webrtc.org/1339253003/diff/100001/webrtc/modules/audio_coding/codecs/isac/fix/source/isac_fix_type.h File webrtc/modules/audio_coding/codecs/isac/fix/source/isac_fix_type.h (right): https://codereview.webrtc.org/1339253003/diff/100001/webrtc/modules/audio_coding/codecs/isac/fix/source/isac_fix_type.h#newcode119 webrtc/modules/audio_coding/codecs/isac/fix/source/isac_fix_type.h:119: enum { kFixSampleRate = 16000 }; I'm sorry to ...
5 years, 3 months ago (2015-09-17 06:08:10 UTC) #2
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-22 09:21:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339253003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339253003/160001
5 years, 3 months ago (2015-09-22 15:24:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/874)
5 years, 3 months ago (2015-09-22 15:26:31 UTC) #9
kwiberg-webrtc
Committed patchset #8 (id:160001) manually as 740436899825b96e12469c417c0ea82fd8a22edf (presubmit successful).
5 years, 3 months ago (2015-09-22 17:31:58 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 17:32:02 UTC) #11
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/740436899825b96e12469c417c0ea82fd8a22edf
Cr-Commit-Position: refs/heads/master@{#10018}

Powered by Google App Engine
This is Rietveld 408576698