Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 1348513003: Android: Add helper class GlTextureFrameBuffer (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Add helper class GlTextureFrameBuffer BUG=webrtc:4993 R=hbos@webrtc.org Committed: https://crrev.com/4a783086b69acc6e31c5244ba983a25c185fa512 Cr-Commit-Position: refs/heads/master@{#9991}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -0 lines) Patch
A talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java View 1 chunk +142 lines, -0 lines 3 comments Download
M talk/libjingle.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
magjed_webrtc
hbos - Please take a look.
5 years, 3 months ago (2015-09-17 14:10:40 UTC) #2
hbos
lgtm, with suggestion to check EGLContext, up to you. https://codereview.webrtc.org/1348513003/diff/1/talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java File talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java (right): https://codereview.webrtc.org/1348513003/diff/1/talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java#newcode37 talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java:37: ...
5 years, 3 months ago (2015-09-18 11:27:35 UTC) #3
magjed_webrtc
https://codereview.webrtc.org/1348513003/diff/1/talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java File talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java (right): https://codereview.webrtc.org/1348513003/diff/1/talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java#newcode46 talk/app/webrtc/java/android/org/webrtc/GlTextureFrameBuffer.java:46: * Generate texture and framebuffer resources. An EGLContext must ...
5 years, 3 months ago (2015-09-18 14:32:03 UTC) #4
magjed_webrtc
Committed patchset #1 (id:1) manually as 4a783086b69acc6e31c5244ba983a25c185fa512 (presubmit successful).
5 years, 3 months ago (2015-09-18 14:32:31 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 14:32:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a783086b69acc6e31c5244ba983a25c185fa512
Cr-Commit-Position: refs/heads/master@{#9991}

Powered by Google App Engine
This is Rietveld 408576698