Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1345913004: Replace readable with receiving where receiving means receiving anything (stun ping, response or da… (Closed)

Created:
5 years, 3 months ago by honghaiz3
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace readable with receiving where receiving means receiving anything (stun ping, response or data packet). BUG=4937 R=pthatcher@webrtc.org Committed: https://crrev.com/04ac81f2fd8ef6680522438fac1894db5415a0ec Cr-Commit-Position: refs/heads/master@{#10004}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -267 lines) Patch
M talk/app/webrtc/statscollector.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M talk/app/webrtc/statstypes.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/statstypes.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 4 chunks +1 line, -20 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 14 chunks +20 lines, -44 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 16 chunks +29 lines, -31 lines 0 comments Download
M webrtc/p2p/base/port.h View 8 chunks +17 lines, -15 lines 0 comments Download
M webrtc/p2p/base/port.cc View 15 chunks +38 lines, -61 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M webrtc/p2p/base/transport.h View 8 chunks +8 lines, -21 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 5 chunks +0 lines, -22 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 4 chunks +6 lines, -9 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M webrtc/p2p/base/transportchannelproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportchannelproxy.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
honghaiz3
5 years, 3 months ago (2015-09-21 16:39:08 UTC) #2
pthatcher1
lgtm https://codereview.webrtc.org/1345913004/diff/20001/webrtc/p2p/base/transportchannel.h File webrtc/p2p/base/transportchannel.h (right): https://codereview.webrtc.org/1345913004/diff/20001/webrtc/p2p/base/transportchannel.h#newcode140 webrtc/p2p/base/transportchannel.h:140: // TODO(honghaiz): remove this once the calling in ...
5 years, 3 months ago (2015-09-21 16:46:02 UTC) #4
honghaiz3
https://codereview.webrtc.org/1345913004/diff/20001/webrtc/p2p/base/transportchannel.h File webrtc/p2p/base/transportchannel.h (right): https://codereview.webrtc.org/1345913004/diff/20001/webrtc/p2p/base/transportchannel.h#newcode140 webrtc/p2p/base/transportchannel.h:140: // TODO(honghaiz): remove this once the calling in a ...
5 years, 3 months ago (2015-09-21 16:55:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345913004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345913004/40001
5 years, 3 months ago (2015-09-21 16:57:55 UTC) #8
pthatcher1
Committed patchset #2 (id:40001) manually as 04ac81f2fd8ef6680522438fac1894db5415a0ec (presubmit successful).
5 years, 3 months ago (2015-09-21 18:48:42 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:48:45 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04ac81f2fd8ef6680522438fac1894db5415a0ec
Cr-Commit-Position: refs/heads/master@{#10004}

Powered by Google App Engine
This is Rietveld 408576698