Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webrtc/p2p/base/transportchannel.cc

Issue 1345913004: Replace readable with receiving where receiving means receiving anything (stun ping, response or da… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/transportchannel.h ('k') | webrtc/p2p/base/transportchannelproxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <sstream> 11 #include <sstream>
12 #include "webrtc/p2p/base/common.h" 12 #include "webrtc/p2p/base/common.h"
13 #include "webrtc/p2p/base/transportchannel.h" 13 #include "webrtc/p2p/base/transportchannel.h"
14 14
15 namespace cricket { 15 namespace cricket {
16 16
17 std::string TransportChannel::ToString() const { 17 std::string TransportChannel::ToString() const {
18 const char READABLE_ABBREV[2] = { '_', 'R' }; 18 const char RECEIVING_ABBREV[2] = { '_', 'R' };
19 const char WRITABLE_ABBREV[2] = { '_', 'W' }; 19 const char WRITABLE_ABBREV[2] = { '_', 'W' };
20 std::stringstream ss; 20 std::stringstream ss;
21 ss << "Channel[" << content_name_ 21 ss << "Channel[" << content_name_ << "|" << component_ << "|"
22 << "|" << component_ 22 << RECEIVING_ABBREV[receiving_] << WRITABLE_ABBREV[writable_] << "]";
23 << "|" << READABLE_ABBREV[readable_] << WRITABLE_ABBREV[writable_] << "]";
24 return ss.str(); 23 return ss.str();
25 } 24 }
26 25
27 void TransportChannel::set_readable(bool readable) {
28 if (readable_ != readable) {
29 readable_ = readable;
30 SignalReadableState(this);
31 }
32 }
33
34 void TransportChannel::set_receiving(bool receiving) { 26 void TransportChannel::set_receiving(bool receiving) {
35 if (receiving_ == receiving) { 27 if (receiving_ == receiving) {
36 return; 28 return;
37 } 29 }
38 receiving_ = receiving; 30 receiving_ = receiving;
39 SignalReceivingState(this); 31 SignalReceivingState(this);
40 } 32 }
41 33
42 void TransportChannel::set_writable(bool writable) { 34 void TransportChannel::set_writable(bool writable) {
43 if (writable_ != writable) { 35 if (writable_ != writable) {
44 LOG_J(LS_VERBOSE, this) << "set_writable from:" << writable_ << " to " 36 LOG_J(LS_VERBOSE, this) << "set_writable from:" << writable_ << " to "
45 << writable; 37 << writable;
46 writable_ = writable; 38 writable_ = writable;
47 if (writable_) { 39 if (writable_) {
48 SignalReadyToSend(this); 40 SignalReadyToSend(this);
49 } 41 }
50 SignalWritableState(this); 42 SignalWritableState(this);
51 } 43 }
52 } 44 }
53 45
54 } // namespace cricket 46 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/p2p/base/transportchannel.h ('k') | webrtc/p2p/base/transportchannelproxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698