Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1344363002: Revert of Bailing out if pc factory fails to get created. (Closed)

Created:
5 years, 3 months ago by phoglund
Modified:
5 years, 3 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Bailing out if pc factory fails to get created. (patchset #1 id:1 of https://codereview.webrtc.org/1339923004/ ) Reason for revert: Breaks goma (??!??!?) Original issue's description: > Bailing out if pc factory fails to get created. > > This prevents us from continuing if we fail initialization. > The failure will happen closer to its source, rather than > when we try to create the first peer connection. > > BUG=None > R=glaznev@webrtc.org > > Committed: https://crrev.com/6eb75d9e67f02c256436eb96f3c77026486561a1 > Cr-Commit-Position: refs/heads/master@{#9948} TBR=glaznev@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/01ddf01d9c787601064a28a01ce60476aeeaa9d0 Cr-Commit-Position: refs/heads/master@{#9949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund
Created Revert of Bailing out if pc factory fails to get created.
5 years, 3 months ago (2015-09-16 07:03:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344363002/1
5 years, 3 months ago (2015-09-16 07:03:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 07:03:47 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 07:03:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01ddf01d9c787601064a28a01ce60476aeeaa9d0
Cr-Commit-Position: refs/heads/master@{#9949}

Powered by Google App Engine
This is Rietveld 408576698