Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1344083004: Remove the SetLocalMonitor() API. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the SetLocalMonitor() API. BUG=webrtc:4690 Committed: https://crrev.com/c1a1b353ec96a92f8b88dba5a058af8744e81560 Cr-Commit-Position: refs/heads/master@{#10020}

Patch Set 1 #

Patch Set 2 : Remove more #

Patch Set 3 : rebase #

Patch Set 4 : remove more #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -125 lines) Patch
M talk/media/base/fakemediaengine.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M talk/media/base/mediaengine.h View 3 chunks +0 lines, -10 lines 0 comments Download
M talk/media/webrtc/fakewebrtcvoiceengine.h View 1 2 5 chunks +0 lines, -23 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 2 3 4 chunks +0 lines, -12 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 6 chunks +1 line, -52 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M talk/session/media/channelmanager.h View 2 chunks +0 lines, -3 lines 0 comments Download
M talk/session/media/channelmanager.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
the sun
5 years, 3 months ago (2015-09-17 10:35:19 UTC) #2
pthatcher1
lgtm
5 years, 3 months ago (2015-09-18 23:19:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344083004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344083004/80001
5 years, 3 months ago (2015-09-22 17:20:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 3 months ago (2015-09-22 19:21:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344083004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344083004/80001
5 years, 3 months ago (2015-09-22 19:38:52 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-22 20:31:26 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 20:31:34 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c1a1b353ec96a92f8b88dba5a058af8744e81560
Cr-Commit-Position: refs/heads/master@{#10020}

Powered by Google App Engine
This is Rietveld 408576698