Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: talk/media/base/mediaengine.h

Issue 1344083004: Remove the SetLocalMonitor() API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/fakemediaengine.h ('k') | talk/media/webrtc/fakewebrtcvoiceengine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/base/mediaengine.h
diff --git a/talk/media/base/mediaengine.h b/talk/media/base/mediaengine.h
index 08addc46400553df42bc9946bf9f118a63d0507c..ad63eb9b6fe8e88d7ac4ad6a8480ed19705fb74b 100644
--- a/talk/media/base/mediaengine.h
+++ b/talk/media/base/mediaengine.h
@@ -113,14 +113,8 @@ class MediaEngineInterface {
// Sets the current speaker volume, as a value between 0 and 255.
virtual bool SetOutputVolume(int level) = 0;
- // Local monitoring
// Gets the current microphone level, as a value between 0 and 10.
virtual int GetInputLevel() = 0;
- // Starts or stops the local microphone. Useful if local mic info is needed
- // prior to a call being connected; the mic will be started automatically
- // when a VoiceMediaChannel starts sending.
- virtual bool SetLocalMonitor(bool enable) = 0;
- // Installs a callback for raw frames from the local camera.
virtual const std::vector<AudioCodec>& audio_codecs() = 0;
virtual const std::vector<RtpHeaderExtension>&
@@ -223,9 +217,6 @@ class CompositeMediaEngine : public MediaEngineInterface {
virtual int GetInputLevel() {
return voice_.GetInputLevel();
}
- virtual bool SetLocalMonitor(bool enable) {
- return voice_.SetLocalMonitor(enable);
- }
virtual const std::vector<AudioCodec>& audio_codecs() {
return voice_.codecs();
}
@@ -289,7 +280,6 @@ class NullVoiceEngine {
}
bool SetOutputVolume(int level) { return true; }
int GetInputLevel() { return 0; }
- bool SetLocalMonitor(bool enable) { return true; }
const std::vector<AudioCodec>& codecs() { return codecs_; }
const std::vector<RtpHeaderExtension>& rtp_header_extensions() {
return rtp_header_extensions_;
« no previous file with comments | « talk/media/base/fakemediaengine.h ('k') | talk/media/webrtc/fakewebrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698