Issue 1343393003: Remove some dead code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1343393003: Remove some dead code. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc

Modified:
5 years, 3 months ago

Reviewers:
henrika_webrtc

CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Remove some dead code. WebRtcPassthroughRender has been dead since webrtcvideoengine.cc was removed, FakeExternalTransport has probably been unused for a long time. BUG=webrtc:1695 R=henrika@webrtc.org Committed: https://crrev.com/f2bfc2b8ef3d774658b9ce3dcd6757f932d071fb Cr-Commit-Position: refs/heads/master@{#9968}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -676 lines)			Patch
M	talk/libjingle.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	talk/libjingle_tests.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	talk/media/webrtc/webrtcpassthroughrender.h	View	1 chunk	+0 lines, -185 lines	0 comments	Download
D	talk/media/webrtc/webrtcpassthroughrender.cc	View	1 chunk	+0 lines, -172 lines	0 comments	Download
D	talk/media/webrtc/webrtcpassthroughrender_unittest.cc	View	1 chunk	+0 lines, -172 lines	0 comments	Download
D	webrtc/voice_engine/test/auto_test/fakes/fake_external_transport.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	webrtc/voice_engine/test/auto_test/fakes/fake_external_transport.cc	View	1 chunk	+0 lines, -96 lines	0 comments	Download
M	webrtc/voice_engine/voice_engine.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pbos-webrtc

PTAL, I've owners in talk/ but need approval for voice_engine/. :)

5 years, 3 months ago (2015-09-17 06:14:13 UTC) #1

pbos-webrtc

Committed patchset #1 (id:1) manually as f2bfc2b8ef3d774658b9ce3dcd6757f932d071fb (presubmit successful).

5 years, 3 months ago (2015-09-17 11:04:28 UTC) #3

commit-bot: I haz the power

5 years, 3 months ago (2015-09-17 11:04:30 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f2bfc2b8ef3d774658b9ce3dcd6757f932d071fb
Cr-Commit-Position: refs/heads/master@{#9968}

Expand Messages | Collapse Messages