Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1343263004: Revert "Android: Enable C99 mode instead of C89 (default)." (Closed)

Created:
5 years, 3 months ago by kjellander_webrtc
Modified:
5 years, 3 months ago
Reviewers:
Andrew MacDonald
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Android: Enable C99 mode instead of C89 (default)." This reverts commit 7bff85c2bc741102b41b259752269f9ecd398d68. It was partially reverted in https://codereview.webrtc.org/1354163002. This reverts the rest. BUG=webrtc:4960, webrtc:5016 TBR=andrew@webrtc.org Committed: https://crrev.com/5bfc6cb53a3923cccbcba439a859fcf42d44fa9f Cr-Commit-Position: refs/heads/master@{#10003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M webrtc/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/build/common.gypi View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_webrtc
5 years, 3 months ago (2015-09-21 14:42:38 UTC) #2
kjellander_webrtc
Committed patchset #1 (id:1) manually as 5bfc6cb53a3923cccbcba439a859fcf42d44fa9f (presubmit successful).
5 years, 3 months ago (2015-09-21 14:51:01 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5bfc6cb53a3923cccbcba439a859fcf42d44fa9f Cr-Commit-Position: refs/heads/master@{#10003}
5 years, 3 months ago (2015-09-21 14:51:06 UTC) #4
Peter Kasting
I don't think this should have been reverted, see bug.
5 years, 3 months ago (2015-09-21 18:16:02 UTC) #5
Andrew MacDonald
5 years, 3 months ago (2015-09-21 19:15:19 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698