Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1354163002: Fix ChromeOS build (C99 break) (Closed)

Created:
5 years, 3 months ago by Henrik Grunell WebRTC
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc, tlegrand-webrtc, kjellander_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix ChromeOS build (C99 break) BUG=webrtc:5016 TBR=henrik.lundin@webrtc.org Committed: https://crrev.com/2803a40fe335a29f9584911d1a52856bdb302df7 Cr-Commit-Position: refs/heads/master@{#9992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/audio_coding/codecs/ilbc/nearest_neighbor.c View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Henrik Grunell WebRTC
5 years, 3 months ago (2015-09-18 13:36:22 UTC) #2
torbjorng (webrtc)
lgtm
5 years, 3 months ago (2015-09-18 13:39:17 UTC) #3
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-18 13:43:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354163002/1
5 years, 3 months ago (2015-09-18 13:44:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 14:50:49 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2803a40fe335a29f9584911d1a52856bdb302df7 Cr-Commit-Position: refs/heads/master@{#9992}
5 years, 3 months ago (2015-09-18 14:51:00 UTC) #8
kjellander_webrtc
So, should we revert the entire https://codereview.webrtc.org/1321193003/ instead to prevent this from happening again? Or ...
5 years, 3 months ago (2015-09-21 07:32:11 UTC) #10
hlundin-webrtc
On 2015/09/21 07:32:11, kjellander (webrtc) wrote: > So, should we revert the entire https://codereview.webrtc.org/1321193003/ > ...
5 years, 3 months ago (2015-09-21 10:58:12 UTC) #11
torbjorng (webrtc)
5 years, 3 months ago (2015-09-21 11:18:43 UTC) #12
Message was sent while issue was closed.
On 2015/09/21 10:58:12, hlundin-webrtc wrote:

> Newer must of course be better. What is their rationale for sticking to C89?

I think it is safe to assume that this is related to that c89 is
still the default mode for compilers.

Let's move to a 16 year old standard and consider the 26 old standard
as deprecated.  :-)

Powered by Google App Engine
This is Rietveld 408576698