Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1339923004: Reland: Bailing out if pc factory fails to get created. (Closed)

Created:
5 years, 3 months ago by phoglund
Modified:
5 years, 1 month ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland: Bailing out if pc factory fails to get created. This was reverted, but it turned out GOMA was down. This prevents us from continuing if we fail initialization. The failure will happen closer to its source, rather than when we try to create the first peer connection. BUG=None R=glaznev@webrtc.org Committed: https://crrev.com/6eb75d9e67f02c256436eb96f3c77026486561a1 Cr-Commit-Position: refs/heads/master@{#9948} Committed: https://crrev.com/fdd1b9a58e4ffbd1442f7d5b1a0bc9c602a8ed5f Cr-Commit-Position: refs/heads/master@{#9974}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
phoglund
5 years, 3 months ago (2015-09-14 13:57:29 UTC) #2
AlexG
lgtm
5 years, 3 months ago (2015-09-14 16:51:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923004/1
5 years, 3 months ago (2015-09-15 07:29:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/9293)
5 years, 3 months ago (2015-09-15 07:41:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923004/1
5 years, 3 months ago (2015-09-15 07:59:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/7316)
5 years, 3 months ago (2015-09-15 14:43:25 UTC) #11
phoglund
Committed patchset #1 (id:1) manually as 6eb75d9e67f02c256436eb96f3c77026486561a1 (presubmit successful).
5 years, 3 months ago (2015-09-16 06:41:48 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6eb75d9e67f02c256436eb96f3c77026486561a1 Cr-Commit-Position: refs/heads/master@{#9948}
5 years, 3 months ago (2015-09-16 06:41:53 UTC) #13
phoglund
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/1344363002/ by phoglund@webrtc.org. ...
5 years, 3 months ago (2015-09-16 07:03:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923004/1
5 years, 3 months ago (2015-09-16 10:00:35 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/2368)
5 years, 3 months ago (2015-09-16 10:28:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923004/1
5 years, 3 months ago (2015-09-16 11:48:55 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/7389)
5 years, 3 months ago (2015-09-16 15:38:33 UTC) #22
phoglund
Committed patchset #2 (id:20001) manually as fdd1b9a58e4ffbd1442f7d5b1a0bc9c602a8ed5f (presubmit successful).
5 years, 3 months ago (2015-09-17 14:46:00 UTC) #23
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 14:46:03 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fdd1b9a58e4ffbd1442f7d5b1a0bc9c602a8ed5f
Cr-Commit-Position: refs/heads/master@{#9974}

Powered by Google App Engine
This is Rietveld 408576698