|
|
DescriptionReland: Bailing out if pc factory fails to get created.
This was reverted, but it turned out GOMA was down.
This prevents us from continuing if we fail initialization.
The failure will happen closer to its source, rather than
when we try to create the first peer connection.
BUG=None
R=glaznev@webrtc.org
Committed: https://crrev.com/6eb75d9e67f02c256436eb96f3c77026486561a1
Cr-Commit-Position: refs/heads/master@{#9948}
Committed: https://crrev.com/fdd1b9a58e4ffbd1442f7d5b1a0bc9c602a8ed5f
Cr-Commit-Position: refs/heads/master@{#9974}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 24 (9 generated)
phoglund@webrtc.org changed reviewers: + glaznev@webrtc.org
lgtm
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/9293)
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/7316)
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 6eb75d9e67f02c256436eb96f3c77026486561a1 (presubmit successful).
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6eb75d9e67f02c256436eb96f3c77026486561a1 Cr-Commit-Position: refs/heads/master@{#9948}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/1344363002/ by phoglund@webrtc.org. The reason for reverting is: Breaks goma (??!??!?).
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as fdd1b9a58e4ffbd1442f7d5b1a0bc9c602a8ed5f (presubmit successful).
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fdd1b9a58e4ffbd1442f7d5b1a0bc9c602a8ed5f Cr-Commit-Position: refs/heads/master@{#9974} |