Remove dependency on Chromium in diagnostic_logging.h.

Remove dependency on Chromium's base/logging.h in diagnostic_logging.h.

Depends on https://codereview.webrtc.org/1335923002/

BUG=chromium:468375
Committed: https://crrev.com/97395b64cab8d3f48b710655d24758a75a32ec12
Cr-Commit-Position: refs/heads/master@{#9965}

[Henrik Grunell WebRTC, 2015-09-14 10:37:25]

henrikg@webrtc.org changed reviewers:
+ andrew@webrtc.org, tommi@webrtc.org

[Andrew MacDonald, 2015-09-14 16:56:20]

To be sure I understand the motivation here: you're rearranging things so only
overrides/.../logging.cc needs to depend on Chromium files. And that's OK
because it will eventually move to the Chromium repo (webrtc_overrides)?

[Henrik Grunell WebRTC, 2015-09-14 19:34:55]

On 2015/09/14 16:56:20, Andrew MacDonald wrote:
> To be sure I understand the motivation here: you're rearranging things so only
> overrides/.../logging.cc needs to depend on Chromium files. And that's OK
> because it will eventually move to the Chromium repo (webrtc_overrides)?

Yes, exactly right.

[Andrew MacDonald, 2015-09-15 01:31:47]

lgtm

[tommi, 2015-09-15 15:06:29]

lgtm

https://codereview.webrtc.org/1338763002/diff/40001/overrides/webrtc/base/log...
File overrides/webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1338763002/diff/40001/overrides/webrtc/base/log...
overrides/webrtc/base/logging.cc:219: // need a macro for the multiline logging.
is this worthy of a bug?

[Henrik Grunell WebRTC, 2015-09-17 07:50:17]

https://codereview.webrtc.org/1338763002/diff/40001/overrides/webrtc/base/log...
File overrides/webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1338763002/diff/40001/overrides/webrtc/base/log...
overrides/webrtc/base/logging.cc:219: // need a macro for the multiline logging.
On 2015/09/15 15:06:29, tommi (webrtc) wrote:
> is this worthy of a bug?

Yes. https://code.google.com/p/webrtc/issues/detail?id=5011

[Henrik Grunell WebRTC, 2015-09-17 07:50:40]

On 2015/09/17 07:50:17, Henrik Grunell (webrtc) wrote:
>
https://codereview.webrtc.org/1338763002/diff/40001/overrides/webrtc/base/log...
> File overrides/webrtc/base/logging.cc (right):
> 
>
https://codereview.webrtc.org/1338763002/diff/40001/overrides/webrtc/base/log...
> overrides/webrtc/base/logging.cc:219: // need a macro for the multiline
logging.
> On 2015/09/15 15:06:29, tommi (webrtc) wrote:
> > is this worthy of a bug?
> 
> Yes. https://code.google.com/p/webrtc/issues/detail?id=5011

Pointed to bug in comment too.

[Henrik Grunell WebRTC, 2015-09-17 07:52:31]

The CQ bit was checked by henrikg@webrtc.org

[Henrik Grunell WebRTC, 2015-09-17 07:52:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
andrew@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1338763002/#ps100001 (title:
"Added bug in comment.")

[commit-bot: I haz the power, 2015-09-17 07:52:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338763002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338763002/100001

[commit-bot: I haz the power, 2015-09-17 09:06:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-09-17 09:06:21]

Patchset 6 (id:??) landed as
https://crrev.com/97395b64cab8d3f48b710655d24758a75a32ec12
Cr-Commit-Position: refs/heads/master@{#9965}