Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webrtc/base/checks.h

Issue 1338763002: Remove dependency on Chromium in diagnostic_logging.h. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@rename_checks
Patch Set: Added bug in comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/overrides/webrtc/base/diagnostic_logging.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/checks.h
diff --git a/webrtc/base/checks.h b/webrtc/base/checks.h
index ad0954d41068ca7e54fb8a1460bc9a319eeab809..98e896a15bfd78850082a2be42a205863cc17988 100644
--- a/webrtc/base/checks.h
+++ b/webrtc/base/checks.h
@@ -14,13 +14,6 @@
#include <sstream>
#include <string>
-#ifdef WEBRTC_CHROMIUM_BUILD
-// Include logging.h in a Chromium build to enable the overrides mechanism for
-// using Chromium's macros. Otherwise, don't depend on logging.h.
-// TODO(ajm): Ideally, checks.h would be combined with logging.h, but
-// consolidation with system_wrappers/logging.h should happen first.
-#include "webrtc/base/logging.h"
-#endif
#include "webrtc/typedefs.h"
// The macros here print a message to stderr and abort under various
@@ -59,6 +52,9 @@
// RTC_DCHECK.
//
// - FATAL() aborts unconditionally.
+//
+// TODO(ajm): Ideally, checks.h would be combined with logging.h, but
+// consolidation with system_wrappers/logging.h should happen first.
namespace rtc {
« no previous file with comments | « no previous file | webrtc/overrides/webrtc/base/diagnostic_logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698