Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1338283002: Remove the preprocessor symbol WEBRTC_CODEC_AVT (it was always defined) (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@ifdef
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the preprocessor symbol WEBRTC_CODEC_AVT (it was always defined) BUG=webrtc:4557 Committed: https://crrev.com/1f9baab753be55a7c6d31c84a5470fe646936edd Cr-Commit-Position: refs/heads/master@{#9960}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M webrtc/engine_configurations.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +1 line, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
kwiberg-webrtc
5 years, 3 months ago (2015-09-14 13:56:28 UTC) #2
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-15 13:07:28 UTC) #3
tlegrand-webrtc
lgtm
5 years, 3 months ago (2015-09-16 07:50:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338283002/1
5 years, 3 months ago (2015-09-16 07:53:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim/builds/2070) linux_gn_rel on tryserver.webrtc (JOB_FAILED, ...
5 years, 3 months ago (2015-09-16 07:54:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338283002/20001
5 years, 3 months ago (2015-09-16 17:28:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_arm64_rel on ...
5 years, 3 months ago (2015-09-16 19:28:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338283002/20001
5 years, 3 months ago (2015-09-17 02:28:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 02:29:48 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 02:29:58 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f9baab753be55a7c6d31c84a5470fe646936edd
Cr-Commit-Position: refs/heads/master@{#9960}

Powered by Google App Engine
This is Rietveld 408576698