Remove the preprocessor symbol WEBRTC_CODEC_PCM16 (it was always defined)

Remove the preprocessor symbol WEBRTC_CODEC_PCM16 (it was always defined)

BUG=webrtc:4557
Committed: https://crrev.com/844a91081ef1141bd9888e828bef87a7737c24a8
Cr-Commit-Position: refs/heads/master@{#9955}

[kwiberg-webrtc, 2015-09-11 11:48:09]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, tina.legrand@webrtc.org

[kwiberg-webrtc, 2015-09-11 11:48:48]

Tina: engine_configurations.h
Henrik: Everything

[hlundin-webrtc, 2015-09-14 06:51:07]

lgtm

https://codereview.webrtc.org/1336923002/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/codec_owner.cc (right):

https://codereview.webrtc.org/1336923002/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/codec_owner.cc:54: return
!STR_CASE_CMP(codec.plname, "l16");
Unrelated to this CL: We have a bit of code duplication between here and
codec_manager.cc. All the Is[SomeCodec] functions are defined twice. Should we
do something about it, or just let it sit until the great refactoring broom
sweeps it away?

[kwiberg-webrtc, 2015-09-14 07:27:26]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-09-14 07:27:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1336923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1336923002/1

[commit-bot: I haz the power, 2015-09-14 07:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 07:29:43]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/726)

[kwiberg-webrtc, 2015-09-14 07:30:07]

https://codereview.webrtc.org/1336923002/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/codec_owner.cc (right):

https://codereview.webrtc.org/1336923002/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/codec_owner.cc:54: return
!STR_CASE_CMP(codec.plname, "l16");
On 2015/09/14 06:51:07, hlundin-webrtc wrote:
> Unrelated to this CL: We have a bit of code duplication between here and
> codec_manager.cc. All the Is[SomeCodec] functions are defined twice. Should we
> do something about it, or just let it sit until the great refactoring broom
> sweeps it away?

Yes, I noticed that too. But since the broom's sweep over this part of the code
is actually scheduled and will happen rather soon, I'd say we just let it sit.

[hlundin-webrtc, 2015-09-14 07:35:57]

https://codereview.webrtc.org/1336923002/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/codec_owner.cc (right):

https://codereview.webrtc.org/1336923002/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/codec_owner.cc:54: return
!STR_CASE_CMP(codec.plname, "l16");
On 2015/09/14 07:30:07, kwiberg-webrtc wrote:
> On 2015/09/14 06:51:07, hlundin-webrtc wrote:
> > Unrelated to this CL: We have a bit of code duplication between here and
> > codec_manager.cc. All the Is[SomeCodec] functions are defined twice. Should
we
> > do something about it, or just let it sit until the great refactoring broom
> > sweeps it away?
> 
> Yes, I noticed that too. But since the broom's sweep over this part of the
code
> is actually scheduled and will happen rather soon, I'd say we just let it sit.

Acknowledged.

[tlegrand-webrtc, 2015-09-16 07:53:10]

lgtm

[kwiberg-webrtc, 2015-09-16 08:00:19]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-09-16 08:00:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1336923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1336923002/1

[commit-bot: I haz the power, 2015-09-16 08:01:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 08:01:48]

Try jobs failed on following builders:
  linux_gn on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn/builds/5568)
  mac on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac/builds/9695)

[kwiberg-webrtc, 2015-09-16 11:10:12]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2015-09-16 11:10:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, tina.legrand@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1336923002/#ps20001 (title:
"rebase")

[commit-bot: I haz the power, 2015-09-16 11:10:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1336923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1336923002/20001

[commit-bot: I haz the power, 2015-09-16 11:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 11:38:00]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[kwiberg-webrtc, 2015-09-16 12:09:26]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-09-16 12:09:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1336923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1336923002/20001

[commit-bot: I haz the power, 2015-09-16 15:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 15:10:49]

Try jobs failed on following builders:
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)

[kwiberg-webrtc, 2015-09-16 15:56:47]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-09-16 15:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1336923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1336923002/20001

[commit-bot: I haz the power, 2015-09-16 16:42:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-16 16:42:36]

Patchset 2 (id:??) landed as
https://crrev.com/844a91081ef1141bd9888e828bef87a7737c24a8
Cr-Commit-Position: refs/heads/master@{#9955}