Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: talk/session/media/channel.cc

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/session/media/channel.cc
diff --git a/talk/session/media/channel.cc b/talk/session/media/channel.cc
index 5a6b7e198f16cb8380790e82d4eda8bc958e4c2a..f06aa123d1e6840a932ff9bce46f629913b10f18 100644
--- a/talk/session/media/channel.cc
+++ b/talk/session/media/channel.cc
@@ -816,7 +816,7 @@ bool BaseChannel::SetDtlsSrtpCiphers(TransportChannel *tc, bool rtcp) {
// We always use the default SRTP ciphers for RTCP, but we may use different
// ciphers for RTP depending on the media type.
if (!rtcp) {
- GetSrtpCiphers(&ciphers);
+ GetSrtpCipherByRfcNames(&ciphers);
} else {
GetSupportedDefaultCryptoSuites(&ciphers);
pthatcher1 2015/09/30 18:39:35 And this should be GetDefaultSrtpCryptoSuiteNames
guoweis_webrtc 2015/09/30 20:14:21 Done.
}
@@ -841,7 +841,7 @@ bool BaseChannel::SetupDtlsSrtp(bool rtcp_channel) {
std::string selected_cipher;
- if (!channel->GetSrtpCipher(&selected_cipher)) {
+ if (!channel->GetSrtpCipherByRfcName(&selected_cipher)) {
LOG(LS_ERROR) << "No DTLS-SRTP selected cipher";
return false;
}
@@ -1627,7 +1627,8 @@ void VoiceChannel::OnSrtpError(uint32 ssrc, SrtpFilter::Mode mode,
}
}
-void VoiceChannel::GetSrtpCiphers(std::vector<std::string>* ciphers) const {
+void VoiceChannel::GetSrtpCipherByRfcNames(
+ std::vector<std::string>* ciphers) const {
GetSupportedAudioCryptoSuites(ciphers);
}
@@ -2060,7 +2061,8 @@ void VideoChannel::OnSrtpError(uint32 ssrc, SrtpFilter::Mode mode,
}
}
-void VideoChannel::GetSrtpCiphers(std::vector<std::string>* ciphers) const {
+void VideoChannel::GetSrtpCipherByRfcNames(
+ std::vector<std::string>* ciphers) const {
GetSupportedVideoCryptoSuites(ciphers);
}
@@ -2395,7 +2397,8 @@ void DataChannel::OnSrtpError(uint32 ssrc, SrtpFilter::Mode mode,
}
}
-void DataChannel::GetSrtpCiphers(std::vector<std::string>* ciphers) const {
+void DataChannel::GetSrtpCipherByRfcNames(
+ std::vector<std::string>* ciphers) const {
GetSupportedDataCryptoSuites(ciphers);
}

Powered by Google App Engine
This is Rietveld 408576698