talk/session/media/channel.h - Issue 1337673002: Change WebRTC SslCipher to be exposed as number only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/session/media/channel.h

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/session/media/channel.h

diff --git a/talk/session/media/channel.h b/talk/session/media/channel.h

index 0a7ce9d1a9e8355bc83ac4433a751ef22deb0354..74fbeea10839622222f6b4395d4c19186a93cde6 100644

--- a/talk/session/media/channel.h

+++ b/talk/session/media/channel.h

@@ -284,7 +284,8 @@ class BaseChannel

// Handled in derived classes

// Get the SRTP ciphers to use for RTP media

- virtual void GetSrtpCiphers(std::vector<std::string>* ciphers) const = 0;

+ virtual void GetSrtpCipherByRfcNames(

+ std::vector<std::string>* ciphers) const = 0;

pthatcher1 2015/09/30 18:39:35 I think a good name here would be GetSrtpCryptoSui

guoweis_webrtc 2015/09/30 20:14:21 Done.

virtual void OnConnectionMonitorUpdate(ConnectionMonitor* monitor,

const std::vector<ConnectionInfo>& infos) = 0;

@@ -413,7 +414,7 @@ class VoiceChannel : public BaseChannel {

bool GetStats_w(VoiceMediaInfo* stats);

virtual void OnMessage(rtc::Message* pmsg);

- virtual void GetSrtpCiphers(std::vector<std::string>* ciphers) const;

+ virtual void GetSrtpCipherByRfcNames(std::vector<std::string>* ciphers) const;

virtual void OnConnectionMonitorUpdate(

ConnectionMonitor* monitor, const std::vector<ConnectionInfo>& infos);

virtual void OnMediaMonitorUpdate(

@@ -510,7 +511,7 @@ class VideoChannel : public BaseChannel {

bool GetStats_w(VideoMediaInfo* stats);

virtual void OnMessage(rtc::Message* pmsg);

- virtual void GetSrtpCiphers(std::vector<std::string>* ciphers) const;

+ virtual void GetSrtpCipherByRfcNames(std::vector<std::string>* ciphers) const;

virtual void OnConnectionMonitorUpdate(

ConnectionMonitor* monitor, const std::vector<ConnectionInfo>& infos);

virtual void OnMediaMonitorUpdate(

@@ -635,7 +636,7 @@ class DataChannel : public BaseChannel {

virtual bool WantsPacket(bool rtcp, rtc::Buffer* packet);

virtual void OnMessage(rtc::Message* pmsg);

- virtual void GetSrtpCiphers(std::vector<std::string>* ciphers) const;

+ virtual void GetSrtpCipherByRfcNames(std::vector<std::string>* ciphers) const;

virtual void OnConnectionMonitorUpdate(

ConnectionMonitor* monitor, const std::vector<ConnectionInfo>& infos);

virtual void OnMediaMonitorUpdate(

« talk/app/webrtc/statscollector_unittest.cc ('K') | « talk/app/webrtc/webrtcsession.cc ('k') | talk/session/media/channel.cc » ('j') | talk/session/media/channel.cc » ('J')