Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/peerconnectioninterface.h
diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h
index ca853385e6327fdcad52014b32abc115685e80c1..c2d21f6434569b23e061f43a595ff889e176fc9d 100644
--- a/talk/app/webrtc/peerconnectioninterface.h
+++ b/talk/app/webrtc/peerconnectioninterface.h
@@ -135,11 +135,16 @@ class MetricsObserverInterface : public rtc::RefCountInterface {
int counter,
int counter_max) {}
+ // This is used to handle sparse counters like SSL cipher suite.
pthatcher1 2015/09/29 22:25:16 cipher suite => cipher suites
guoweis_webrtc 2015/09/30 04:09:46 Done.
+ // TODO(guoweis): Remove the implementation once the dependency's interface
+ // definition is updated.
+ virtual void IncrementSparseEnumCounter(PeerConnectionEnumCounterType type,
+ int counter) {
+ IncrementEnumCounter(type, counter, 0 /* Ignored */);
+ }
+
virtual void AddHistogramSample(PeerConnectionMetricsName type,
int value) = 0;
- // TODO(jbauch): Make method abstract when it is implemented by Chromium.
- virtual void AddHistogramSample(PeerConnectionMetricsName type,
- const std::string& value) {}
protected:
virtual ~MetricsObserverInterface() {}

Powered by Google App Engine
This is Rietveld 408576698