Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 class MetricsObserverInterface : public rtc::RefCountInterface { 128 class MetricsObserverInterface : public rtc::RefCountInterface {
129 public: 129 public:
130 130
131 // |type| is the type of the enum counter to be incremented. |counter| 131 // |type| is the type of the enum counter to be incremented. |counter|
132 // is the particular counter in that type. |counter_max| is the next sequence 132 // is the particular counter in that type. |counter_max| is the next sequence
133 // number after the highest counter. 133 // number after the highest counter.
134 virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type, 134 virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type,
135 int counter, 135 int counter,
136 int counter_max) {} 136 int counter_max) {}
137 137
138 // This is used to handle sparse counters like SSL cipher suite.
pthatcher1 2015/09/29 22:25:16 cipher suite => cipher suites
guoweis_webrtc 2015/09/30 04:09:46 Done.
139 // TODO(guoweis): Remove the implementation once the dependency's interface
140 // definition is updated.
141 virtual void IncrementSparseEnumCounter(PeerConnectionEnumCounterType type,
142 int counter) {
143 IncrementEnumCounter(type, counter, 0 /* Ignored */);
144 }
145
138 virtual void AddHistogramSample(PeerConnectionMetricsName type, 146 virtual void AddHistogramSample(PeerConnectionMetricsName type,
139 int value) = 0; 147 int value) = 0;
140 // TODO(jbauch): Make method abstract when it is implemented by Chromium.
141 virtual void AddHistogramSample(PeerConnectionMetricsName type,
142 const std::string& value) {}
143 148
144 protected: 149 protected:
145 virtual ~MetricsObserverInterface() {} 150 virtual ~MetricsObserverInterface() {}
146 }; 151 };
147 152
148 typedef MetricsObserverInterface UMAObserver; 153 typedef MetricsObserverInterface UMAObserver;
149 154
150 class PeerConnectionInterface : public rtc::RefCountInterface { 155 class PeerConnectionInterface : public rtc::RefCountInterface {
151 public: 156 public:
152 // See http://dev.w3.org/2011/webrtc/editor/webrtc.html#state-definitions . 157 // See http://dev.w3.org/2011/webrtc/editor/webrtc.html#state-definitions .
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 CreatePeerConnectionFactory( 603 CreatePeerConnectionFactory(
599 rtc::Thread* worker_thread, 604 rtc::Thread* worker_thread,
600 rtc::Thread* signaling_thread, 605 rtc::Thread* signaling_thread,
601 AudioDeviceModule* default_adm, 606 AudioDeviceModule* default_adm,
602 cricket::WebRtcVideoEncoderFactory* encoder_factory, 607 cricket::WebRtcVideoEncoderFactory* encoder_factory,
603 cricket::WebRtcVideoDecoderFactory* decoder_factory); 608 cricket::WebRtcVideoDecoderFactory* decoder_factory);
604 609
605 } // namespace webrtc 610 } // namespace webrtc
606 611
607 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_ 612 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698