talk/media/webrtc/webrtcvideoengine2.cc - Issue 1334793003: Remove VideoMediaChannel::SetRender().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/media/webrtc/webrtcvideoengine2.cc

Issue 1334793003: Remove VideoMediaChannel::SetRender(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Remove fake SetRender Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/media/webrtc/webrtcvideoengine2.cc

diff --git a/talk/media/webrtc/webrtcvideoengine2.cc b/talk/media/webrtc/webrtcvideoengine2.cc

index e94c0b1794919c854b26205fa26e912962db27b9..8f07fe9d69aa29f82646438b704748ac8c918976 100644

--- a/talk/media/webrtc/webrtcvideoengine2.cc

+++ b/talk/media/webrtc/webrtcvideoengine2.cc

@@ -1074,12 +1074,6 @@ bool WebRtcVideoChannel2::SetSendStreamFormat(uint32 ssrc,

return send_streams_[ssrc]->SetVideoFormat(format);

}

-bool WebRtcVideoChannel2::SetRender(bool render) {

- // TODO(pbos): Implement. Or refactor away as it shouldn't be needed.

- LOG(LS_VERBOSE) << "SetRender: " << (render ? "true" : "false");

- return true;

bool WebRtcVideoChannel2::SetSend(bool send) {

LOG(LS_VERBOSE) << "SetSend: " << (send ? "true" : "false");

if (send && !send_codec_.IsSet()) {