talk/session/media/channel.cc - Issue 1334793003: Remove VideoMediaChannel::SetRender().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/session/media/channel.cc

Issue 1334793003: Remove VideoMediaChannel::SetRender(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Remove fake SetRender Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/session/media/channel.cc

diff --git a/talk/session/media/channel.cc b/talk/session/media/channel.cc

index 294681ef1449aa94033112e8e5315cec5048a0f7..091878a4e1957a0a1c2f8e24dbf5dc318dd01871 100644

--- a/talk/session/media/channel.cc

+++ b/talk/session/media/channel.cc

@@ -1717,10 +1717,6 @@ void VideoChannel::ChangeState() {

// Render incoming data if we're the active call, and we have the local

// content. We receive data on the default channel and multiplexed streams.

bool recv = IsReadyToReceive();

pthatcher1 2015/09/16 22:18:22 Might as well remove |recv| and the LOG(LS_INFO) b

pbos-webrtc 2015/09/24 16:44:38 Done.

- if (!media_channel()->SetRender(recv)) {

- LOG(LS_ERROR) << "Failed to SetRender on video channel";

- // TODO(gangji): Report error back to server.

- }

// Send outgoing data if we're the active call, we have the remote content,

// and we have had some form of connectivity.

« no previous file with comments | « talk/media/webrtc/webrtcvideoengine2_unittest.cc ('k') | no next file » | no next file with comments »