Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1332573003: Change return type of AudioEncoder::SetMaxPlaybackRate to void (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@ifc-merge-2
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change return type of AudioEncoder::SetMaxPlaybackRate to void There's no point in returning a status code, since the max playback rate is only a suggestion that the encoder is free to disregard. Committed: https://crrev.com/3f5f1c2ad305a665fb2ecd3e31c57d405e19af97 Cr-Commit-Position: refs/heads/master@{#9900}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-08 12:43:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332573003/1
5 years, 3 months ago (2015-09-09 06:10:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 06:15:37 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 06:15:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f5f1c2ad305a665fb2ecd3e31c57d405e19af97
Cr-Commit-Position: refs/heads/master@{#9900}

Powered by Google App Engine
This is Rietveld 408576698