webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc - Issue 1332573003: Change return type of AudioEncoder::SetMaxPlaybackRate to void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

Issue 1332573003: Change return type of AudioEncoder::SetMaxPlaybackRate to void (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@ifc-merge-2

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h ('k') | webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

diff --git a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

index e750aa1323b9bfdfa1b42be7a7869202d41307c6..a68530e4159acecdfa7f0b914ce80cf54d5c6bcd 100644

--- a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

+++ b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

@@ -190,10 +190,10 @@ bool AudioEncoderOpus::SetApplication(Application application) {

return RecreateEncoderInstance(conf);

}

-bool AudioEncoderOpus::SetMaxPlaybackRate(int frequency_hz) {

+void AudioEncoderOpus::SetMaxPlaybackRate(int frequency_hz) {

auto conf = config_;

conf.max_playback_rate_hz = frequency_hz;

- return RecreateEncoderInstance(conf);

+ CHECK(RecreateEncoderInstance(conf));

}

void AudioEncoderOpus::SetProjectedPacketLossRate(double fraction) {