Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1331853002: ACM CodecOwner: Test that we reset speech encoder when enabling CNG or RED (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@mark
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

ACM CodecOwner: Test that we reset speech encoder when enabling CNG or RED If we don't, we'll end up crashing if they're enabled when the speech encoder is in the middle of encoding a packet, since CNG and RED assume that the speech encoder starts out with an empty buffer (because they need to be in sync with it). BUG=chromium:490368 Committed: https://crrev.com/39720f2669e34dbfb55fe3c6eb38e4331b231ae5 Cr-Commit-Position: refs/heads/master@{#9917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc View 2 chunks +51 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
kwiberg-webrtc
👀
5 years, 3 months ago (2015-09-10 11:35:10 UTC) #2
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-10 12:04:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331853002/1
5 years, 3 months ago (2015-09-10 12:11:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 12:44:52 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 12:45:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39720f2669e34dbfb55fe3c6eb38e4331b231ae5
Cr-Commit-Position: refs/heads/master@{#9917}

Powered by Google App Engine
This is Rietveld 408576698