Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1331793003: MockAudioEncoder: Use a dedicated marker method for test expectations (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MockAudioEncoder: Use a dedicated marker method for test expectations This makes the sequence of expected calls easier to read. Also, we can save one line and get rid of a gmock warning by expecting the MockAudioEncoder object to be destroyed at the end of the test instead of making a final marker call. Committed: https://crrev.com/9b66d3ba608b33515420b6fe658afed7d5b19f18 Cr-Commit-Position: refs/heads/master@{#9916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
kwiberg-webrtc
Prerequisite for https://codereview.webrtc.org/1331853002/.
5 years, 3 months ago (2015-09-10 11:31:55 UTC) #2
hlundin-webrtc
Nice. LGTM.
5 years, 3 months ago (2015-09-10 12:01:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331793003/1
5 years, 3 months ago (2015-09-10 12:06:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 12:09:49 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 12:09:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b66d3ba608b33515420b6fe658afed7d5b19f18
Cr-Commit-Position: refs/heads/master@{#9916}

Powered by Google App Engine
This is Rietveld 408576698