Index: webrtc/base/sslstreamadapter.h |
diff --git a/webrtc/base/sslstreamadapter.h b/webrtc/base/sslstreamadapter.h |
index 4fb238a290482d13d00569bc57ccc5cdc45389f8..47360e972985dda7b9353215b872cda8e1a6e64d 100644 |
--- a/webrtc/base/sslstreamadapter.h |
+++ b/webrtc/base/sslstreamadapter.h |
@@ -167,9 +167,9 @@ class SSLStreamAdapter : public StreamAdapterInterface { |
// Returns the default Ssl cipher used between streams of this class |
// for the given protocol version. This is used by the unit tests. |
- // TODO(torbjorng@webrtc.org): Fix callers to avoid default parameter. |
+ static std::string GetDefaultSslCipher(SSLProtocolVersion version); |
juberti
2015/09/29 16:44:05
Why do we need to pass KeyTypeFull here? This func
torbjorng (webrtc)
2015/10/01 11:43:19
It was convenient, but I now instead changed calle
|
static std::string GetDefaultSslCipher(SSLProtocolVersion version, |
- KeyType key_type = KT_DEFAULT); |
+ KeyTypeFull key_type); |
hbos
2015/09/29 13:53:18
Can we do default param key_type = KeyTypeFull::De
torbjorng (webrtc)
2015/10/01 11:43:19
Default arguments are frowned upon:
https://google
hbos
2015/10/01 14:42:43
Acknowledged.
|
private: |
// If true, the server certificate need not match the configured |