Provide RSA2048 as per RFC

webrtc/base/sslstreamadapter.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 149 matching lines @@
   virtual bool SetDtlsSrtpCiphers(const std::vector<std::string>& ciphers);
   virtual bool GetDtlsSrtpCipher(std::string* cipher);
 
   // Capabilities testing
   static bool HaveDtls();
   static bool HaveDtlsSrtp();
   static bool HaveExporter();
 
   // Returns the default Ssl cipher used between streams of this class
   // for the given protocol version. This is used by the unit tests.
-  // TODO(torbjorng@webrtc.org): Fix callers to avoid default parameter.
+  static std::string GetDefaultSslCipher(SSLProtocolVersion version);

[juberti, 2015/09/29 16:44:05]

Why do we need to pass KeyTypeFull here? This function should not care about RSA
key size.

[torbjorng (webrtc), 2015/10/01 11:43:19]

It was convenient, but I now instead changed callers (and also
cleaned up the default parameter usage from an old CL).

   static std::string GetDefaultSslCipher(SSLProtocolVersion version,
-                                         KeyType key_type = KT_DEFAULT);
+                                         KeyTypeFull key_type);

[hbos, 2015/09/29 13:53:18]

Can we do default param key_type = KeyTypeFull::Default() instead of two
functions?

[torbjorng (webrtc), 2015/10/01 11:43:19]

Default arguments are frowned upon:
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html

[hbos, 2015/10/01 14:42:43]

Acknowledged.

 
  private:
   // If true, the server certificate need not match the configured
   // server_name, and in fact missing certificate authority and other
   // verification errors are ignored.
   bool ignore_bad_cert_;
 
   // If true (default), the client is required to provide a certificate during
   // handshake. If no certificate is given, handshake fails. This applies to
   // server mode only.
   bool client_auth_enabled_;
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_SSLSTREAMADAPTER_H_