Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: talk/media/base/videoengine_unittest.h

Issue 1327933003: Enable probing with repeated payload packets by default. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix additional tests. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/base/videoengine_unittest.h
diff --git a/talk/media/base/videoengine_unittest.h b/talk/media/base/videoengine_unittest.h
index 5f00a0eca3c5399508667c93fc3c1257f265a6c5..cb6fbe7e01ab06ac7552200903087a8be4692013 100644
--- a/talk/media/base/videoengine_unittest.h
+++ b/talk/media/base/videoengine_unittest.h
@@ -1050,7 +1050,7 @@ class VideoMediaChannelTest : public testing::Test,
EXPECT_TRUE(channel_->SetRenderer(kDefaultReceiveSsrc, &renderer_));
EXPECT_TRUE(SendFrame());
EXPECT_FRAME_WAIT(1, DefaultCodec().width, DefaultCodec().height, kTimeout);
- EXPECT_GE(2, NumRtpPackets());
+ EXPECT_GT(NumRtpPackets(), 0);
mflodman 2015/09/08 12:33:50 Why this change?
stefan-webrtc 2015/09/08 13:17:34 It's no longer true that you only get 2 packets. T
mflodman 2015/09/08 18:32:03 It used to be '>= 2', not '==', and now it's '> 0'
stefan-webrtc 2015/09/09 09:20:53 Oh, good point. I think I changed it by mistake. O
stefan-webrtc 2015/09/09 09:22:59 Sorry, I forgot why I change this. Notice that pre
uint32 ssrc = 0;
size_t last_packet = NumRtpPackets() - 1;
rtc::scoped_ptr<const rtc::Buffer>
@@ -1718,7 +1718,7 @@ class VideoMediaChannelTest : public testing::Test,
SendAndReceive(codec);
// Test sending and receiving on second stream.
EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
- EXPECT_EQ(2, NumRtpPackets());
+ EXPECT_GT(NumRtpPackets(), 0);
EXPECT_EQ(1, renderer2_.num_rendered_frames());
}
« no previous file with comments | « no previous file | webrtc/modules/pacing/include/paced_sender.h » ('j') | webrtc/modules/rtp_rtcp/source/rtp_sender.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698